Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to check if CCM is disabled, and not run if it is the case #45

Merged
merged 1 commit into from
Aug 12, 2015

Conversation

stdweird
Copy link
Member

@stdweird stdweird commented Jun 5, 2015

If the check-noquattor option is set (e.g. in the config file), do not run anything if CCM is disabled globally via the /etc/noquattor file. This allows admins to fully disable quattor when performing manual tasks and doing testing, including reboots (which normally trigger ncm-cdispd (re)start and thus also ncm-ncd).

@stdweird
Copy link
Member Author

stdweird commented Jun 5, 2015

This is only one patch, the PR is based on #44

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/ncm-ncd-pr-builder/113/
Test PASSed (test).

@stdweird
Copy link
Member Author

stdweird commented Jun 5, 2015

@ned21 @jrha @jouvin more option names that might make no sense 😄
i'm also amused that we have no component to deal with the ncm-ncd config file (although the format is easy to generate, the correct functioning/logic is not)

@stdweird stdweird added this to the 15.6 milestone Jun 5, 2015
…lly via /etc/noquattor, and if so, do not run anything.
@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/ncm-ncd-pr-builder/115/
Test PASSed (test).

@stdweird
Copy link
Member Author

stdweird commented Aug 6, 2015

@ned21 rebased on master, and mergeable now

@stdweird
Copy link
Member Author

stdweird commented Aug 7, 2015

to generate the ncm-ncd.conf with check-noquattor = 1, you can use quattor/configuration-modules-core#543

@ned21
Copy link
Contributor

ned21 commented Aug 9, 2015

LGTM. The PR has been open for a while so I assume no one has any objections to the functionality or better suggestions for option naming?

@samary
Copy link

samary commented Aug 10, 2015

Nice, it will be useful. Thanks !

jrha added a commit that referenced this pull request Aug 12, 2015
Add option to check if CCM is disabled, and not run if it is the case
@jrha jrha merged commit f2a04ce into quattor:master Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants