Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aquilon installation: various refinements #255

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Jul 26, 2018

  • Miscellaneous changes in the template examples, based on LAL experience
  • Document AII installack configuration for Aquilon, in particular when sharing an AII server between SCDB and Aquilon

@jouvin jouvin requested review from jrha and ned21 July 26, 2018 09:45
@jrha
Copy link
Member

jrha commented Jul 26, 2018

Tests are failing due to what looks like issues with GitHub.

@jouvin
Copy link
Contributor Author

jouvin commented Jul 26, 2018

Test failure is due to spellchecker issue stfc/markdown-spellchecker#11. @jrha do you prefer that I add the necessary entries in the dictionary to make the spell checker happy or do we live with these errors until the issue is fixed (probably better than polluting the dictionary if there is any hope to fix the issue in the coming months...

@jrha
Copy link
Member

jrha commented Jul 26, 2018

I was referring to the link errors from htmlproofer:

There is one real spell checker error, feel free to ignore the false ones, it's probably better not to pollute the dictionary, the fix should be trivial.

@jouvin
Copy link
Contributor Author

jouvin commented Jul 26, 2018

@jrha sorry I didn't see your original comment, mine was not an answer to yours, just a general remark! I think I fixed the real error but I let you confirm that the ones remaining are ok.

# This variable will allow to control the YUM snapshot used, if you are using YUM
# Define the default suffix for YUM-based variant of RPMS configuration templates
# Defined too late by the standard templates in the context of Aquilon
variable RPMS_CONFIG_SUFFIX ?= '-yd';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen this variable before so shouldn't really comment on it but -yd seems an odd suffix to me?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ned21 this variable is used by the template library as a template name suffix in various places where we wanted to support both the SPMA package list and a YUM-based package list. For backward compatibility, without the suffix you were getting the SPMA list and you needed to have this variable defined to -yd to get the YUM-based list. I don't even remember why -yd (y was probably for YUM). I think we may clean up this in the future as I don't think there are many non YUM system left nowadays but it is important to have this variable defined if you use the template library. Else several pieces don't work as expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment about the standard definition being done to late is due to the fact that this variable is defined in quattor/client/config which is included in final.pan with Aquilon (as it has a dependency on the OS version variable which is not yet available in base.pan (typically defined in the OS template).

@ned21
Copy link
Contributor

ned21 commented Jul 27, 2018

Most of the content here is related to parts of Quattor we don't use but nothing looks incorrect from an Aq perspective.

@jouvin
Copy link
Contributor Author

jouvin commented Aug 27, 2018

@jrha @ned21 anything I should do to get this PR merged?

@ned21
Copy link
Contributor

ned21 commented Aug 27, 2018

@jouvin I am not familiar with much of the material here so would prefer someone else to do the final review.

@jrha jrha merged commit dc93124 into quattor:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants