Refactor quattor/schema #58
Conversation
quattor/types This commit has the minimal set of changes required (in particular, no cleanup of the templates).
|
Test PASSed. |
|
|
||
| declaration template quattor/blockdevices; | ||
|
|
||
| include {"quattor/physdevices"}; | ||
| include { 'quattor/physdevices' }; |
There was a problem hiding this comment.
You could even remote quotes as we decided for panc 10.2 as the minimum required panc version (in fact this works since 10.0).
|
Test PASSed. |
|
If quattor/maven-tools#42 gets merged/released, this PR will also be required, because component schemas can't be validated without it. |
|
Can you update the annotations to use |
| # | ||
| ############################################################ | ||
| @{ | ||
| Type definitions for block devices. |
There was a problem hiding this comment.
desc = Type definitions for block devices
There was a problem hiding this comment.
reading http://quattor-pan.readthedocs.org/en/latest/pan-book/pan-book.html?highlight=annotation, desc seems to be used for functions (and require the @documentation{}).
…hey compile to xml)
|
Refer to this link for build results (access rights to CI server needed): |
|
@jrha i updated according to panbook. |
|
Nice, looks good now, @jouvin please merge if you are happy. |
quattor/schemacan't be used from thetemplate-library-corerepository due to the missingmonitoring/lemon/schema.With the refactor,it is now possible for components to include only the component relevant types and nothing else, so we can unittest the templates shipped by e.g. the components with only dependency on this repo.