new function template #90
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
test this please |
|
test this please |
| @@ -0,0 +1,29 @@ | |||
| declaration template quattor/functions/strings; | |||
|
|
|||
| include { 'pan/functions' }; | |||
|
This looks good, it could do with some documentation to explain how it "compares" versions. Also: four space indentation please. |
| }; | ||
| }; | ||
|
|
||
| return(0); |
There was a problem hiding this comment.
You can leave out the return() here and just assert 0
There was a problem hiding this comment.
in fact you must leave out the return()... Having an explicit return() is handled internally as an exception adn breaks the parallelism into the compiler... return must be used only when it is required to break the normal execution flow... (in fact there are quite a lot of useless return in the template library coming from the ancient times...)
|
No longer required. |
Hi,
as it was needed for some grid storage configuration, I wrote a function comparing versions numbers (a simple string comparison does not do the jobs). I guess this may be a function of general interest so it would be nice to have in under some standard path. I'm not sure this (quattor/functions) is the correct location where to put the template, so, please let me know which is the best way to proceed.
Cheers,
a.