Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cvmfs extra repos #72

Merged
merged 3 commits into from
Jul 1, 2016
Merged

Cvmfs extra repos #72

merged 3 commits into from
Jul 1, 2016

Conversation

pigay
Copy link
Contributor

@pigay pigay commented Jul 1, 2016

Allows users to configure extra CVMFS repositories and domains through CVMFS_EXTRA_REPOSITORIES and CVMFS_EXTRA_DOMAINS variables.

It also factorizes the configuration code for existing repositories.

An example for France Grilles repository:

variable CVMFS_EXTRA_REPOSITORIES ?= nlist('francegrilles.in2p3.fr',
                                           nlist('server_urls', nlist('CC-IN2P3', 'http://cccrnvmfss1li01.in2p3.fr/cvmfs/francegrilles.in2p3.fr'),
                                           'pubkeys_file', 'cvmfs/keys/francegrilles.in2p3.fr.pub'
                                           ),
                                     );

@Pansanel: This PR is far better than your #71 ;)

@jouvin: You are right, ncm-metaconfig should be better, in deed. I'll try to have a look at it soon (hopefully).

@Pansanel
Copy link
Contributor

Pansanel commented Jul 1, 2016

@pigay: it is a good refactory. Can you rebase on my previous PR and include metaconfig changes?

@pigay
Copy link
Contributor Author

pigay commented Jul 1, 2016

Do you mean I need to include francegrilles.in2p3.fr specific configuration (including public key) in the template-library? I had the feeling that this library should be restricted to general purpose code (which also applies to the other domains data such as desy and gridpp and maybe cern too, by the way). These details should fit better in another library (template-library-grid for example), don't you think?

Note: I don't have any metaconfig code yet...

@jouvin
Copy link
Contributor

jouvin commented Jul 1, 2016

@pigay cvmfs is in the template-library-standard and everything related should be there. You are right that we may want to find a way to describe repo servers in a more generic way to avoid adding code for adding repo. In the meantime, this modification is acceptable for me as changing it should not affect the site configuration (the use of the new code is triggered by the name of the repos used at site which is independent of the configuration itself). I open #73 to track this.

@jouvin jouvin merged commit 7f1b0b7 into quattor:master Jul 1, 2016
@jrha jrha added this to the 16.6 milestone Jul 1, 2016
@pigay pigay mentioned this pull request Aug 31, 2016
@jouvin jouvin mentioned this pull request Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants