-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update documentation to account for self generating vuln DB #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
force-pushed
the
update-readme-updates
branch
from
June 17, 2024 22:32
b22a77d
to
8796973
Compare
closes #99 |
This was
linked to
issues
Jun 24, 2024
hdonnay
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed, I think.
README.md
Outdated
run: | | ||
docker save -o ${{ github.sha }} crozzy/great-app:${{ github.sha }} | ||
- name: Run Clair V4 | ||
uses: quay/clair-action@allow-update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
uses: quay/clair-action@allow-update | |
uses: quay/clair-action@main |
This should probably have the same ref as the codeblock above?
Previously we had hosted a security DB that was updated nightly but as previously stated, this is no longer tenable. In place of this we added some machinary to allow users to (hopefully) easily generate it. This change updates the README to reflect those changes. Signed-off-by: crozzy <joseph.crosland@gmail.com>
crozzy
force-pushed
the
update-readme-updates
branch
from
June 24, 2024 19:59
8796973
to
a7a7195
Compare
hdonnay
approved these changes
Jun 24, 2024
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had hosted a security DB that was updated nightly but as previously stated, this is no longer tenable. In place of this we added some machinary to allow users to (hopefully) easily generate it. This change updates the README to reflect those changes.