Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] database: add support mysql #114

Closed
wants to merge 1 commit into from
Closed

[WIP] database: add support mysql #114

wants to merge 1 commit into from

Conversation

coolljt0725
Copy link
Contributor

Signed-off-by: Lei Jitang leijitang@huawei.com
#61

This is work in progress, most code are the same with pgsql include the unit tests, all the tests can pass execpt complex_test.go flaky, sometimes it pass and some times fail, I need fix this. And the code is not clean.
I don't know if this is the right approach to implement mysql, I need some feedback and then move on.

@coolljt0725
database: add support mysql
3ba218d 
Signed-off-by: Lei Jitang <leijitang@huawei.com>
@Quentin-M
Copy link
Contributor

Hi !

Thanks for the WIP.

How different is it from the pgsql driver? This looks like a lot of duplicated code.
Couldn't we just abstract the pgsql driver a bit instead? Would a library like gorm fit since they support SQL Builder now (recursive queries...)?

@jzelinskie jzelinskie added kind/design relates to the fundamental design of a component kind/feature request wishes for new functionality/docs lacking/review needs to be reviewed by a maintainer component/database labels Mar 22, 2016
@coolljt0725
Copy link
Contributor Author

@Quentin-M Yes, there are a lot of duplicated code, I'll refactor in the next step

@jzelinskie jzelinskie added reviewed/needs rework will be closed if review not addressed and removed lacking/review needs to be reviewed by a maintainer labels Mar 25, 2016
@nmaas87
Copy link

nmaas87 commented Jan 5, 2017

Does Clair support mysql now :)?

@jzelinskie
Copy link
Contributor

This PR is quite old now and needs a lot of work to integrate into the current version of Clair.
Anyone still interested in implementing a MySQL backend for Clair should wait for the next major release (v3.0.0) in which we will have a new interface that should make implementing MySQL support significantly more simple.

@jzelinskie jzelinskie closed this Aug 14, 2017
@mowangdk
Copy link

Does Clair support mysql now ？。。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/design relates to the fundamental design of a component kind/feature request wishes for new functionality/docs reviewed/needs rework will be closed if review not addressed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coolljt0725 @Quentin-M @nmaas87 @jzelinskie @mowangdk