-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6/6] introspection: remove disused argument #1974
Draft
hdonnay
wants to merge
6
commits into
quay:hdonnay/introspection-lints
Choose a base branch
from
hdonnay:hack/healthmetrics
base: hdonnay/introspection-lints
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[6/6] introspection: remove disused argument #1974
hdonnay
wants to merge
6
commits into
quay:hdonnay/introspection-lints
from
hdonnay:hack/healthmetrics
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdonnay
force-pushed
the
hack/healthmetrics
branch
4 times, most recently
from
February 15, 2024 17:13
4fcfd81
to
efe68fc
Compare
hdonnay
force-pushed
the
hack/healthmetrics
branch
from
April 9, 2024 21:44
efe68fc
to
2b838df
Compare
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
This should allow a Clair instance to use the "native" OpenTelemetry transport for metrics and traces. Some parts of Clair and Claircore are directly instrumented with Prometheus, and so the OTLP support should be considered beta-quality. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
This updates the `local-dev` stack. Most of these updates were needed to test the OpenTelemetry support. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
This is replaced by the metrics-powered health check. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
force-pushed
the
hack/healthmetrics
branch
from
July 23, 2024 20:26
2b838df
to
61a1619
Compare
hdonnay
changed the title
health: PoC for health checks via otel metrics
[6/6] introspection: remove disused argument
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
introspection: remove disused argument
This is replaced by the metrics-powered health check.
Signed-off-by: Hank Donnay hdonnay@redhat.com