Initial services refactoring of database.Datastore #198
Conversation
| import ( | ||
| "github.com/coreos/clair/services" | ||
| "time" | ||
| ) | ||
|
|
||
| // MockDatastore implements Datastore and enables overriding each available method. | ||
| // The default behavior of each method is to simply panic. | ||
| type MockDatastore struct { |
There was a problem hiding this comment.
We should probably break this down into a few different MockXxxService types to parallel the refactor.
There was a problem hiding this comment.
Will do, I'll post to the main comment thread once updated.
This breaks out the following service interfaces: - locks.Service - keyvalue.Service - notifications.Service - vulnerabilities.Service This also updates the Mock implementations along similar lines. Make Travis work on my fork by rsyncing the build dir as coreos/clair
mattmoor
force-pushed
the
starter-services
branch
from
71a5d23
to
c823c39
Compare
|
Ok, this is RFAL. |
jzelinskie
added
kind/design
| @@ -24,7 +24,10 @@ import ( | |||
| "github.com/prometheus/client_golang/prometheus" | |||
|
|
|||
| "github.com/coreos/clair/config" | |||
| "github.com/coreos/clair/database" | |||
| "github.com/coreos/clair/services/keyvalue" | |||
There was a problem hiding this comment.
All other services use the plural form
|
I don't really like reading |
|
Is there a reason that we have one package per service interface? Wouldn't be nice to have: |
|
Configuration hasn't been updated (yet?), therefore, we can't specify configuration on a service basis. |
|
@mattmoor is there still interest in getting this cleaned up and merged? |
|
Sorry for the delayed response. Unless you guys really want some aspect of this change, I'm happy to abandon this PR. I unblocked myself by other means. |
this commit changes the ClairV4 image to use ubi8 and rpm 4.14.2 fixes: quay#198 Jira: PROJQUAY-1015 Signed-off-by: ldelossa <ldelossa@redhat.com>
this commit changes the ClairV4 image to use ubi8 and rpm 4.14.2 fixes: quay#198 Jira: PROJQUAY-1015 Signed-off-by: ldelossa <ldelossa@redhat.com>
this commit changes the ClairV4 image to use ubi8 and rpm 4.14.2 fixes: #198 Jira: PROJQUAY-1015 Signed-off-by: ldelossa <ldelossa@redhat.com>
this commit changes the ClairV4 image to use ubi8 and rpm 4.14.2 fixes: #198 Jira: PROJQUAY-1015 Signed-off-by: ldelossa <ldelossa@redhat.com>
this commit changes the ClairV4 image to use ubi8 and rpm 4.14.2 fixes: quay#198 Jira: PROJQUAY-1015 Signed-off-by: ldelossa <ldelossa@redhat.com>
This breaks out the following service interfaces:
Make Travis work on my fork by rsyncing the build dir as coreos/clair
This replaces: #194