Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: extract filename information #1300

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Mar 29, 2024

This should allow us to extract a list of known file patterns for use later in the Indexer pipeline.

@hdonnay hdonnay requested a review from a team as a code owner March 29, 2024 21:22
@hdonnay hdonnay requested review from crozzy and removed request for a team March 29, 2024 21:22
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 67.64706% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 55.80%. Comparing base (e8f9aff) to head (a24db2a).

Files Patch % Lines
rpm/native_db.go 67.64% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
+ Coverage   55.76%   55.80%   +0.03%     
==========================================
  Files         265      265              
  Lines       16562    16596      +34     
==========================================
+ Hits         9236     9261      +25     
- Misses       6365     6375      +10     
+ Partials      961      960       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hdonnay hdonnay force-pushed the hack/rpm-files branch 2 times, most recently from 33ac1d1 to 2287a34 Compare March 29, 2024 21:32
rpm/native_db.go Outdated Show resolved Hide resolved
@hdonnay hdonnay force-pushed the hack/rpm-files branch 2 times, most recently from 703eaf0 to 05789ac Compare April 9, 2024 16:57
@hdonnay hdonnay force-pushed the hack/rpm-files branch 2 times, most recently from 78d832e to 754f932 Compare April 15, 2024 18:10
@hdonnay hdonnay requested a review from jvdm April 15, 2024 21:03
@hdonnay hdonnay force-pushed the hack/rpm-files branch 2 times, most recently from b1e2f67 to a3db7b2 Compare April 15, 2024 22:28
This should allow us to extract a list of known file patterns for use
later in the Indexer pipeline.

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
Copy link
Member Author

hdonnay commented Apr 15, 2024

Added tests

@hdonnay
Copy link
Member Author

hdonnay commented Apr 19, 2024

/fast-forward

@github-actions github-actions bot merged commit a24db2a into quay:main Apr 19, 2024
8 checks passed
@hdonnay hdonnay deleted the hack/rpm-files branch April 25, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants