rpm: implement an RPM filescanner to discern RPM filepaths #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
force-pushed
the
rpm-filescanner
branch
2 times, most recently
from
21db95f
to
f1bafd3
Compare
hdonnay
reviewed
Apr 12, 2024
| @@ -5,6 +5,7 @@ type FileKind string | |||
|
|
|||
| const ( | |||
| FileKindWhiteout = FileKind("whiteout") | |||
| FileKindRPM = FileKind("rpm") | |||
There was a problem hiding this comment.
So every file's "kind" is effectively the component that noticed it?
There was a problem hiding this comment.
I suppose in theory any filescanner can create any FileKind and any Resolver can be interested in any FileType or perhaps multiple in the future, so the name is kind of arbitrary. Do you think the kind could be better named?
crozzy
force-pushed
the
rpm-filescanner
branch
4 times, most recently
from
6e33ee1
to
217186a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1320 +/- ##
==========================================
+ Coverage 56.24% 56.33% +0.08%
==========================================
Files 266 268 +2
Lines 16838 16939 +101
==========================================
+ Hits 9471 9542 +71
- Misses 6402 6421 +19
- Partials 965 976 +11 ☔ View full report in Codecov by Sentry. |
crozzy
force-pushed
the
rpm-filescanner
branch
6 times, most recently
from
a248d33
to
9faca9c
Compare
|
I think I'll probably add some more test cases to the resolver but it'd be good to get some eyes on again. |
crozzy
force-pushed
the
rpm-filescanner
branch
4 times, most recently
from
66ca82d
to
74673cc
Compare
We should be accounting for more than one file per layer and therefore this change (from map[layer_id]claircore.File to map[layer_id][]claircore.File) is needed. Signed-off-by: crozzy <joseph.crosland@gmail.com>
Using the filepaths discovered by the RPM filescanner we can judge whether or not a language package has been installed via RPM or not. Signed-off-by: crozzy <joseph.crosland@gmail.com>
The Resolver compares file paths gleaned from RPM DBs and compares them to a Package.Filepath to try and determine if a package needs to be removed from an index report because its RPM counterpart has already been included. Signed-off-by: crozzy <joseph.crosland@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the filepaths discovered by the RPM filescanner we can judge whether or not a language package has been installed via RPM or not.
TODO: