Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove reflection zero type when zero value is known (PROJQUAY-6620) #112

Merged
merged 1 commit into from
Mar 7, 2024

Commits on Mar 6, 2024

  1. chore: remove reflection zero type when zero value is known (PROJQUAY…

    …-6620)
    
    reflection uses unsafe types and is cpu intensive. we can reduce cpu
    cycles on every api call by simple comparing an empty strings equality
    to the value of the AuthToken.
    
    strings.EqualFold is a std lib solution that provides similar
    functionality, but that is not necessary for comparing empty strings as
    it simply uses the standard equality operator as well
    
    Topic: rm-reflection
    
    Relative: projquay-6620
    Signed-off-by: Ross Bryan <robryan@redhat.com>
    arborite-rh committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    fe678d0 View commit details
    Browse the repository at this point in the history