-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove reflection zero type when zero value is known (PROJQUAY-6620) #112
Conversation
Reviews in this chain: |
|
7fd04c7
to
4c07622
Compare
4c07622
to
ecb31c3
Compare
…-6620) reflection uses unsafe types and is cpu intensive. we can reduce cpu cycles on every api call by simple comparing an empty strings equality to the value of the AuthToken. strings.EqualFold is a std lib solution that provides similar functionality, but that is not necessary for comparing empty strings as it simply uses the standard equality operator as well Topic: rm-reflection Relative: projquay-6620 Signed-off-by: Ross Bryan <robryan@redhat.com>
ecb31c3
to
96f5a36
Compare
96f5a36
to
fe678d0
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arborite-rh, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
reflection uses unsafe types and is cpu intensive. we can reduce cpu
cycles on every api call by simple comparing an empty strings equality
to the value of the AuthToken.
strings.EqualFold is a std lib solution that provides similar
functionality, but that is not necessary for comparing empty strings as
it simply uses the standard equality operator as well
Topic: rm-reflection
Relative: projquay-6620
Signed-off-by: Ross Bryan robryan@redhat.com