route: Check for routes only if the component is managed (PROJQUAY-6007) #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsurf
force-pushed
the
projquay-6007
branch
from
3355d81
to
f8502c4
Compare
harishsurf
changed the title
|
@harishsurf Can you address the failed unit tests? |
harishsurf
force-pushed
the
projquay-6007
branch
2 times, most recently
from
f0023e3
to
9084d5f
Compare
harishsurf
force-pushed
the
projquay-6007
branch
from
6e4aacd
to
0444c3b
Compare
|
/retest-required |
|
@harishsurf can we merge this PR? |
|
@jonathankingfc, this needs to be refactored to move out setting routes here outside of the checkRoutesAvailable. (more details added on slack for context) |
Signed-off-by: harishsurf <hgovinda@redhat.com>
harishsurf
force-pushed
the
projquay-6007
branch
from
a6eb45f
to
90d66d5
Compare
|
/cherry-pick redhat-3.10 |
|
@harishsurf: new pull request created: #883 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for routes only if the component is managed by the operator