Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: proper capitalization of routes (PROJQUAY-6395) #2473

Closed
wants to merge 1 commit into from

Conversation

dmesser
Copy link
Contributor

@dmesser dmesser commented Nov 12, 2023

This changes the breadcrumb creation logic from a mere parsing of the URL route to create the breadcrumb titles to recognition of known route components so that we can display the words Repository and Organization in the breadcrumb display with the first letter in capital case.
Screenshot 2023-11-12 at 21 02 37

Screenshot 2023-11-12 at 21 02 47

Signed-off-by: dmesser <dmesser@redhat.com>
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@Sunandadadi
Copy link
Contributor

@dmesser I changed the logic for breadcrumb creation in this PR. I strictly follow the route and form the breadcrumb item based off of it. This JIRA is something I am working on to fix the capitalization of text across the new ui.

@dmesser
Copy link
Contributor Author

dmesser commented Nov 15, 2023

@Sunandadadi, that's great to hear. Sounds like my PR is obsolete then. Btw, in your PR #1893 in its current form, I think we are still expecting lowercase organization and repository in the breadcrumb visuzatlion:

cy.wrap($el).should('have.text', 'organization');

@dmesser dmesser closed this Nov 15, 2023
@Sunandadadi
Copy link
Contributor

@dmesser yes, I have this PR where I fix capitalisation of texts in multiple place. I will add the same for breadcrumbs here too.

@dmesser dmesser deleted the typo-fixes branch November 16, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants