Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: following capitalisation guidelines in the new ui (PROJQUAY-6247) #2488

Merged
merged 12 commits into from
Nov 22, 2023

Conversation

Sunandadadi
Copy link
Contributor

@Sunandadadi Sunandadadi commented Nov 14, 2023

Based on the capitalisation guidelines across Red Hat UIs mentioned here - https://www.patternfly.org/ux-writing/capitalization/#capitalization-across-red-hat-uis

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b6b159) 70.55% compared to head (831da11) 70.55%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
- Coverage   70.55%   70.55%   -0.01%     
==========================================
  Files         434      434              
  Lines       39826    39826              
  Branches     5164     5164              
==========================================
- Hits        28100    28099       -1     
- Misses      10102    10104       +2     
+ Partials     1624     1623       -1     
Flag Coverage Δ
unit 70.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sunandadadi Sunandadadi changed the title ui: unifying title text to follow sentance case (PROJQUAY-6247) ui: following capitalisation guidelines in the new ui (PROJQUAY-6247) Nov 16, 2023
Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sunandadadi Sunandadadi merged commit a7b448c into quay:master Nov 22, 2023
15 checks passed
@Sunandadadi Sunandadadi deleted the PROJQUAY-6247 branch November 22, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants