marketplace: consider new skus in exclusion (PROJQUAY-6905) #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2794 +/- ##
=======================================
Coverage 70.93% 70.93%
=======================================
Files 436 436
Lines 40708 40722 +14
Branches 5318 5323 +5
=======================================
+ Hits 28875 28885 +10
- Misses 10150 10154 +4
Partials 1683 1683
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kleesc
approved these changes
Mar 26, 2024
dmesser
pushed a commit
to dmesser/quay
that referenced
this pull request
Apr 16, 2024
check if sku is part of reconciler skus when getting list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds clause to filter out skus with
masterEndSystemName=SUBSCRIPTIONto also be reconciler skus. This allows new skus used for purchase orders to still work.