Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MBIS interface #259

Merged
merged 18 commits into from
Apr 20, 2021
Merged

[WIP] MBIS interface #259

merged 18 commits into from
Apr 20, 2021

Conversation

jthorton
Copy link
Contributor

Description

This PR provides an interface to MBIS via the latest version of PSI4.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Add an MBIS interface
  • Add psi4 solvent calculations
  • Add Gaussian solvent calculation support via QCEngine
  • Update Vsites to be a pydantic stage
  • Update Lennard Jones to be a pydantic stage

Questions

  • Although we can not test the gaussian code in the CI should we add tests that we can run locally to make sure everything works?
  • What should the default solvent be for PSI4 or should we just expose this will we fit new parameters?

Status

  • Ready to go

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 16, 2021

This pull request introduces 1 alert when merging 67af9d8 into b46ff91 - view on LGTM.com

new alerts:

  • 1 for Conflicting attributes in base classes

@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #259 (33123aa) into master (b46ff91) will increase coverage by 0.33%.
The diff coverage is 65.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   63.96%   64.29%   +0.33%     
==========================================
  Files          44       54      +10     
  Lines        4934     5165     +231     
==========================================
+ Hits         3156     3321     +165     
- Misses       1778     1844      +66     
Impacted Files Coverage Δ
qubekit/molecules/ligand.py 96.61% <ø> (-0.01%) ⬇️
qubekit/proteins/protein_run.py 0.00% <0.00%> (ø)
qubekit/utils/configs.py 26.38% <ø> (+0.36%) ⬆️
qubekit/utils/file_handling.py 88.00% <ø> (+41.03%) ⬆️
qubekit/run.py 24.60% <17.24%> (-0.29%) ⬇️
qubekit/engines/gaussian_harness.py 83.23% <30.76%> (-3.72%) ⬇️
qubekit/charges/utils.py 34.96% <34.96%> (ø)
qubekit/charges/mbis.py 44.11% <44.11%> (ø)
qubekit/charges/ddec.py 58.92% <58.92%> (ø)
qubekit/charges/base.py 71.79% <71.79%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46ff91...33123aa. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 19, 2021

This pull request introduces 1 alert when merging 13ce576 into b46ff91 - view on LGTM.com

new alerts:

  • 1 for Conflicting attributes in base classes

@jthorton jthorton merged commit e03a7d1 into master Apr 20, 2021
@jthorton jthorton deleted the mbis branch April 20, 2021 13:35
@jthorton jthorton mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant