new: dev: Add support for ClusterManage Command #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me other than indentation. Travis complains that there is a mix of space and tabs. Surprised it didnt fail in 2.X |
| @@ -421,7 +447,7 @@ def _parse_snapshot_restore_command(cls, args, action): | |||
| Parse command line arguments for snapshot command. | |||
| """ | |||
| argparser = ArgumentParser(prog="cluster %s" % action) | |||
|
|
|||
There was a problem hiding this comment.
Get rid of these whitespace changes.
There was a problem hiding this comment.
However, if these are trailing whitespace removals - then they are welcome.
|
Fixed all the indentation issues(Finally). Can this be merged now? |
|
Oh oh - I messed up. Didnt squash it |
|
Shall I rebase everything here? so you can reset hard and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed the comments in pull request #91 and opening on against unreleased branch.