Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More minor tweaks #722

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Conversation

mgberg
Copy link
Contributor

@mgberg mgberg commented Jun 28, 2023

This includes the following:

  • Add rdfs:Resource as an explicit superclass of qudt:Concept in the SHACL schema as all other classes defined there have an explicit superclass and some tools complain about one not existing
  • Standardize a symbol for one unit
  • Replace Kilogram?force with Kilogram Force in the labels for a few units

@jhodgesatmb
Copy link
Collaborator

jhodgesatmb commented Jun 28, 2023 via email

@mgberg
Copy link
Contributor Author

mgberg commented Jun 28, 2023

@jhodgesatmb I've updated those labels per your above comment.

@steveraysteveray
Copy link
Collaborator

Unfortunately, now I have a problem! The phrase "Kilogram Force Meter" is misleading (to me) because the first blank stands in for "of" while the second blank means "multiplied by".

I would suggest we include the word "of", as in "Kilogram of force Meter"
Thoughts, anyone?

@mgberg
Copy link
Contributor Author

mgberg commented Jun 28, 2023

Unfortunately, now I have a problem! The phrase "Kilogram Force Meter" is misleading (to me) because the first blank stands in for "of" while the second blank means "multiplied by".

I would suggest we include the word "of", as in "Kilogram of force Meter" Thoughts, anyone?

Yeah that's why I originally had the hyphen. It's not uncommon to write the gravitational force units with the corresponding mass unit followed by -force. For example, see the Wikipedia page.

@jhodgesatmb
Copy link
Collaborator

jhodgesatmb commented Jun 28, 2023 via email

@mgberg
Copy link
Contributor Author

mgberg commented Jun 28, 2023

I'm curious about the context for that discussion. I can definitely understand a desire to create more standardized labels. However, why would one expect a label, which (in general) exists to be human-readable and match what the community would identify with, to derive from the lname convention which (in general) does not need to be human-readable?

In this case, I don't think it's inaccurate to say that the "normal"/"expected" way to write this is kilogram-force; in fact, a quick Google search will show it written that way a large majority of the time. It doesn't seem that different than how Centimeter of Water is a "normal" way to write out unit:CM_H2O.

@jhodgesatmb
Copy link
Collaborator

jhodgesatmb commented Jun 28, 2023 via email

@mgberg
Copy link
Contributor Author

mgberg commented Jun 29, 2023

I made the change.

@jhodgesatmb jhodgesatmb merged commit d4edca8 into qudt:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants