New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check host instance source #197

Merged

Neonox31 merged 1 commit into quentinlampin:next from airbusgeo:fix-check-host-instance-source

Oct 2, 2018

Contributor

aymeric-duchein commented Oct 1, 2018 •

edited

Loading

The instance wasn't checked causing some Cannot read property 'setSource' of undefined when using *ngIf or other structural directives.

@Neonox31 @davinkevin @Yakoust @dabbid


          fix(source): check host instance before setSource

aymeric-duchein changed the base branch from master to next

October 1, 2018 12:03

Contributor

Yakoust commented Oct 2, 2018

LGTM 👍

Neonox31 merged commit 8bfd7b2 into quentinlampin:next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet