Improve null handling

querydsl · Apr 6, 2016 · a6d14a2 · a6d14a2
1 parent 5cdb0e3
commit a6d14a2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/querydsl-sql/src/main/java/com/querydsl/sql/Configuration.java b/querydsl-sql/src/main/java/com/querydsl/sql/Configuration.java
@@ -107,7 +107,7 @@ public Configuration(SQLTemplates templates) {
      */
     @SuppressWarnings("unchecked")
     public String asLiteral(Object o) {
-        if (Null.class.isInstance(o)) {
+        if (o == null || o instanceof Null) {
             return "null";
         } else {
             Type type = javaTypeMapping.getType(o.getClass());
@@ -222,7 +222,7 @@ public String getColumnOverride(SchemaAndTable key, String column) {
      */
     @SuppressWarnings({ "unchecked", "rawtypes" })
     public <T> void set(PreparedStatement stmt, Path<?> path, int i, T value) throws SQLException {
-        if (Null.class.isInstance(value)) {
+        if (value == null || value instanceof Null) {
             Integer sqlType = null;
             if (path != null) {
                 ColumnMetadata columnMetadata = ColumnMetadata.getColumnMetadata(path);

diff --git a/querydsl-sql/src/test/java/com/querydsl/sql/SelectBase.java b/querydsl-sql/src/test/java/com/querydsl/sql/SelectBase.java
@@ -895,6 +895,12 @@ public void in_empty() {
         assertEquals(0, query().from(employee).where(employee.id.in(ImmutableList.<Integer>of())).fetchCount());
     }
 
+    @Test
+    @ExcludeIn(DERBY)
+    public void in_null() {
+        assertEquals(1, query().from(employee).where(employee.id.in(1, null)).fetchCount());
+    }
+
     @Test
     @ExcludeIn({MYSQL, TERADATA})
     public void in_subqueries() {