-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve numeric mappings #1200
Improve numeric mappings #1200
Conversation
Conflicts: querydsl-sql/src/main/java/com/querydsl/sql/JDBCTypeMapping.java - changes near the class header
return numericTypes.get(key); | ||
} else if (decimal <= 0) { | ||
private static Class<?> getNumericClass(int total, int decimal) { | ||
if (decimal <= 0) { | ||
if (total > 18 || total == 0) { | ||
return BigInteger.class; | ||
} else if (total > 9 || total == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Total can only be 0 once.
Is this what was intended?
@@ -69,8 +69,7 @@ public void NumericTypes() { | |||
// 2,0 -> Byte | |||
// 0-1,0 -> Boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now we can update these comments, since Boolean isn't used in numeric types?
In my opinion this is now also good to merge. |
Ok, good. |
Fixes #1194 and #1025