Use of Hibernate 5.3 and HibernateQuery results in "Could not locate named parameter"

[andygoossens]

The use of querydsl-jpa's HibernateQuery with Hibernate 5.3 will thrown an exception when you use parameters:

java.lang.IllegalArgumentException: Could not locate named parameter [1], expecting one of []

	at org.hibernate.query.internal.ParameterMetadataImpl.getNamedParameterDescriptor(ParameterMetadataImpl.java:218)
	at org.hibernate.query.internal.ParameterMetadataImpl.getQueryParameter(ParameterMetadataImpl.java:187)
	at org.hibernate.query.internal.QueryParameterBindingsImpl.getBinding(QueryParameterBindingsImpl.java:188)
	at org.hibernate.query.internal.AbstractProducedQuery.setParameter(AbstractProducedQuery.java:494)
	at org.hibernate.query.internal.AbstractProducedQuery.setParameter(AbstractProducedQuery.java:107)
	at com.querydsl.jpa.hibernate.HibernateUtil.setValue(HibernateUtil.java:91)
	at com.querydsl.jpa.hibernate.HibernateUtil.setConstants(HibernateUtil.java:79)
	at com.querydsl.jpa.hibernate.AbstractHibernateQuery.createQuery(AbstractHibernateQuery.java:105)
	at com.querydsl.jpa.hibernate.AbstractHibernateQuery.createQuery(AbstractHibernateQuery.java:97)
	at com.querydsl.jpa.hibernate.AbstractHibernateQuery.fetch(AbstractHibernateQuery.java:174)
	at com.querydsl.example.jpa.repository.TweetRepository.findAllWithHibernateQuery(TweetRepository.java:30)
	at com.google.inject.persist.jpa.JpaLocalTxnInterceptor.invoke(JpaLocalTxnInterceptor.java:66)
	at com.querydsl.example.jpa.repository.TweetRepositoryTest.find_list_by_predicate(TweetRepositoryTest.java:44)

I am not the only person experiencing this error, as @jpimag experienced the same issue:
#2283 (comment)

To reproduce this issue, I modified the querydsl-example-jpa-guice example contained within the QueryDSL repository. You can find the patch here:
https://gist.github.com/andygoossens/5eed865ccfe84857f7e99ddb2dfb5790
Then just run test class com.querydsl.example.jpa.repository.TweetRepositoryTest and check whether it fails.

You can easily compare the different behaviour between Hibernate versions by altering the <hibernate.version> parameter in the POM file (part of the "hibernate5" profile). e.g. Hibernate version 5.2.17.Final works fine, but version 5.3.1.Final fails. Don't forget to activate the necessary Maven profile(s) of course! :-)

It looks like there is a mixup between named query parameters and positional query parameters. getConstantToLabel() could contain a constant with index "1" (as a String and meant to be used as ?1) but QueryDSL is calling Query<R> setParameter(String name, Object val); meant for named parameters (like :example). Hibernate does not find the named parameter "1" and fails.

[jpimag]

Thanks for your research.
I think this is due to a drop of legacy parameter support in hibernate 5.3
https://hibernate.atlassian.net/browse/HHH-12116

[Shredder121]

Oh, so the recent Hibernate version did in fact not reestablish backwards compatibility?

[andygoossens]

This issue is unrelated to #1917.

QueryDSL relied on Hibernate's behaviour that a positional parameter was basically a named parameter. This is no longer the case since 5.3.0.Beta1 (see the Hibernate ticket that @jpimag mentioned above).

From now on, QueryDSL needs to keep its positional parameters separated from the named parameters. Even though we have noticed this issue with Hibernate 5.3, a fix would also work with older versions. So in theory, there is no need to wait for QueryDSL 5.x and a patch could already be applied to QueryDSL's 4.x branches (obviously depends on whether the effort is worth it).

[andygoossens]

Someone else discovered the same issue and worked around it:
Unimarket@7a7994c#diff-01d72489db0f2d9a9e2853fcc4d703a1
Unimarket@f7184a0#diff-6cf0d9d4e9431be92cccfbc859d0c1f0

That is not the proper fix as SerializerBase could have prefixed the number with a String, which will cause Integer.parseInt(key) to fail.

[PavlikPolivka]

Hi.
Is somebody working on the fix for this?
We want to migrate to Hibernate 5.3 and we are hitting this error.
I can try to do the correct fix over the weekend if nobody is working on this.

[andygoossens]

@PavlikPolivka: I don't think that anybody started creating a proper fix for it. Feel free to work on it.

[Shredder121]

Could you test if the recent Hibernate versions?
I don't know what they've restored backwards compatibility with, but they did something.

[PavlikPolivka]

I am experiencing this with latest hibernate and latest query dsl. Hibernate fixed all their binary compatibilies (as far as I know) this is caused by hibernate fixing a way parameters are interpreted (correctly fixing) and query dsl is using the wrong version.

…

On Sat, 11 Aug 2018 at 11:42, Ruben Dijkstra ***@***.***> wrote: Could you test if the recent Hibernate versions? I don't know what they've restored backwards compatibility with, but they did something <#1917 (comment)>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2326 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHJtrsYH70n52yZXV88Eks1X-iiPR452ks5uPqcEgaJpZM4U0a5z> .

[PavlikPolivka]

So. If I change this to number based parametrs it works ok with Hibernte 5.3.
If I run the test with Hibernate 4 I get
org.hibernate.QueryParameterException: Position beyond number of declared ordinal parameters. Remember that ordinal parameters are 1-based! Position: 2 that is strange. I definitely see it as parameter number 1. It works fine when I set it as string.

This means that if this fix is accepted there is incopatibility for hibernate 4.x.

[m4urer]

What's going on with this? Is there going to be a new querydsl release with 5.3.x compatibility?
I was originally waiting for the fix for hibernate 5.2 ... now 5.3 is out ... is there a plan?
Querydsl is starting to feel a bit neglected ... is the idea to keep it alive and up to date on your part?
Thanks!

[Shredder121]

Yes, of course it is. I'm just currently busy with other things that impact my future, as I've stated in multiple other threads, and the google group, when I have more time on my hands to work on my hobby I will.

[jfcabral]

@Shredder121 is there anything we can do to help sorting this out?
QueryDSL is such an useful framework! But I'm affraid that for Spring Boot users (v >=2.1), Hibernate 5.3 support is a must!
Thank you

[zvozin]

Is anyone working on, or planning to work on, patching this?

[idosal]

Fixed in #2354. It will be featured in the next official release, which will also remove support for Hibernate 4. For now, you can try it out in 4.2.3-SNAPSHOT. I'd appreciate your feedback. Thanks!