-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please update to current JTS version (org.locationtech.jts:jts-core:1.16.0) #2404
Comments
Sounds like a good plan,thanks! |
Hibernate spatial 5.4 depends on org.geolatte:geolatte-geom:1.4.0 which in turn depends on the org.locationtech.jts:jts-core:1.16.0 So currently the latest version of querydsl spatial is incompatible with the latest version of hibernate spatial. |
Tried a quick upgrade in PR #2418. All but PolyHedralSurface was simple find and replace. Any ideas how to fix those? |
I tried to get little further in a separate branch https://github.com/mstahv/querydsl/tree/feature/geolatte-and-jtsupgrade-removed-polyhedral by just removing the PolyHedralSurface stuff. It appears there is a lot to do still in sql-spatial module 😥 |
How is this going? |
I haven't had time to work on this lately. Summer cottage project disturbing my OSS contributions 😥 I hope somebody can take over my PR. |
If anyone would like to take over this PR I'll be happy to merge it. Please note that spatial probably won't be in active development by the team going forward. |
@mstahv, what more needs to be done on your branch? It makes sense for you to just remove the PolyHedralSurface components because Goelatte removed these in GeoLatte/geolatte-geom@edc901f. Also to point out this was removed over 6 years ago. I don't think it is coming back. The comment states they reworked their position based geometries, so maybe after these changes it this model was no longer needed. @idosal do you know anything he is missing on his branch? |
The SQL module stuff apparently..
|
Yep, I think the only easy way out is to remove polyhedral features and related tests at this point. IIRC (it has been a while), I found no way how to support them now. I'd be honoured if somebody would continue my work on this. I'd love to upgrade one of my examples to newer Hibernate, but I probably don't have time for this before the autumn due to my building project. |
I think everyones onboard with removing polyhedral features. Are there any other test failures in the SQL module that you remember? If no one else picks it up in the mean time, I am willing to work on it but I first have to finish up some of my other pending OSS contributions. |
I removed some more instances of polyhedral features and merged in master on my fork. When I ran the test though there was failures, oddly in parts that didn't relate to geospatial objects. |
[#2404] Upgrade GeoLatte to 1.4.0
Please exchange the old jts dependency with the maintained successor:
https://mvnrepository.com/artifact/org.locationtech.jts/jts-core/1.16.0
The text was updated successfully, but these errors were encountered: