Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update to current JTS version (org.locationtech.jts:jts-core:1.16.0) #2404

Closed
tucek opened this issue Jan 11, 2019 · 12 comments · Fixed by #2713
Closed

Please update to current JTS version (org.locationtech.jts:jts-core:1.16.0) #2404

tucek opened this issue Jan 11, 2019 · 12 comments · Fixed by #2713
Assignees
Labels
Milestone

Comments

@tucek
Copy link

tucek commented Jan 11, 2019

Please exchange the old jts dependency with the maintained successor:
https://mvnrepository.com/artifact/org.locationtech.jts/jts-core/1.16.0

@Shredder121 Shredder121 added this to the 5.0 milestone Jan 11, 2019
@Shredder121
Copy link
Member

Sounds like a good plan,thanks!

@tucek
Copy link
Author

tucek commented Jan 11, 2019

Hibernate spatial 5.4 depends on org.geolatte:geolatte-geom:1.4.0 which in turn depends on the org.locationtech.jts:jts-core:1.16.0

So currently the latest version of querydsl spatial is incompatible with the latest version of hibernate spatial.

@mstahv
Copy link
Contributor

mstahv commented Feb 18, 2019

Tried a quick upgrade in PR #2418. All but PolyHedralSurface was simple find and replace. Any ideas how to fix those?

@mstahv
Copy link
Contributor

mstahv commented Feb 18, 2019

I tried to get little further in a separate branch https://github.com/mstahv/querydsl/tree/feature/geolatte-and-jtsupgrade-removed-polyhedral by just removing the PolyHedralSurface stuff. It appears there is a lot to do still in sql-spatial module 😥

@ddcruver
Copy link

How is this going?

@mstahv
Copy link
Contributor

mstahv commented Jan 10, 2020

I haven't had time to work on this lately. Summer cottage project disturbing my OSS contributions 😥 I hope somebody can take over my PR.

@idosal
Copy link
Member

idosal commented Jan 10, 2020

If anyone would like to take over this PR I'll be happy to merge it. Please note that spatial probably won't be in active development by the team going forward.

@ddcruver
Copy link

@mstahv, what more needs to be done on your branch?

It makes sense for you to just remove the PolyHedralSurface components because Goelatte removed these in GeoLatte/geolatte-geom@edc901f.

Also to point out this was removed over 6 years ago. I don't think it is coming back. The comment states they reworked their position based geometries, so maybe after these changes it this model was no longer needed.

@idosal do you know anything he is missing on his branch?

@jwgmeligmeyling
Copy link
Member

The SQL module stuff apparently..

It appears there is a lot to do still in sql-spatial module

@mstahv
Copy link
Contributor

mstahv commented Jan 29, 2020

Yep, I think the only easy way out is to remove polyhedral features and related tests at this point. IIRC (it has been a while), I found no way how to support them now.

I'd be honoured if somebody would continue my work on this. I'd love to upgrade one of my examples to newer Hibernate, but I probably don't have time for this before the autumn due to my building project.

@jwgmeligmeyling
Copy link
Member

I think everyones onboard with removing polyhedral features. Are there any other test failures in the SQL module that you remember?

If no one else picks it up in the mean time, I am willing to work on it but I first have to finish up some of my other pending OSS contributions.

@ddcruver
Copy link

I removed some more instances of polyhedral features and merged in master on my fork. When I ran the test though there was failures, oddly in parts that didn't relate to geospatial objects.

@jwgmeligmeyling jwgmeligmeyling self-assigned this Dec 31, 2020
jwgmeligmeyling added a commit that referenced this issue Jan 2, 2021
Fixes #2404
Fixes #2292
Closes #2418
Closes #2584
Closes #2670

Co-authored-by: Matti Tahvonen <matti@vaadin.com>
Co-authored-by: Kochkurov <kochkurovn@gmail.com>
Co-authored-by: Kyösti Herrala <kyosti.herrala@vincit.fi>
jwgmeligmeyling added a commit that referenced this issue Jan 2, 2021
Fixes #2404
Fixes #2292
Closes #2418
Closes #2584
Closes #2670

Co-authored-by: Matti Tahvonen <matti@vaadin.com>
Co-authored-by: Kochkurov <kochkurovn@gmail.com>
Co-authored-by: Kyösti Herrala <kyosti.herrala@vincit.fi>
jwgmeligmeyling added a commit that referenced this issue Jan 2, 2021
Fixes #2404
Fixes #2292
Closes #2418
Closes #2584
Closes #2670

Co-authored-by: Matti Tahvonen <matti@vaadin.com>
Co-authored-by: Kochkurov <kochkurovn@gmail.com>
Co-authored-by: Kyösti Herrala <kyosti.herrala@vincit.fi>
jwgmeligmeyling added a commit that referenced this issue Jan 2, 2021
Fixes #2404
Fixes #2292
Closes #2418
Closes #2584
Closes #2670

Co-authored-by: Matti Tahvonen <matti@vaadin.com>
Co-authored-by: Kochkurov <kochkurovn@gmail.com>
Co-authored-by: Kyösti Herrala <kyosti.herrala@vincit.fi>
jwgmeligmeyling added a commit that referenced this issue Jan 2, 2021
Fixes #2404
Fixes #2292
Closes #2418
Closes #2584
Closes #2670

Co-authored-by: Matti Tahvonen <matti@vaadin.com>
Co-authored-by: Kochkurov <kochkurovn@gmail.com>
Co-authored-by: Kyösti Herrala <kyosti.herrala@vincit.fi>
jwgmeligmeyling added a commit that referenced this issue Jan 2, 2021
Fixes #2404
Closes #2418
Closes #2584
Closes #2670

Co-authored-by: Matti Tahvonen <matti@vaadin.com>
Co-authored-by: Kochkurov <kochkurovn@gmail.com>
Co-authored-by: Kyösti Herrala <kyosti.herrala@vincit.fi>
jwgmeligmeyling added a commit that referenced this issue Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment