Target Java 8 for compilation #2672
Conversation
| @@ -15,8 +15,8 @@ | |||
| @Test | |||
| public void sum() throws Exception { | |||
| NumberPath<BigDecimal> num = Expressions.numberPath(BigDecimal.class, "num"); | |||
| CollQuery<?> query = CollQueryFactory.from(num, Arrays.asList(new BigDecimal("1.6"), new BigDecimal("1.3"))); | |||
| CollQuery<BigDecimal> query = CollQueryFactory.<BigDecimal> from(num, Arrays.<BigDecimal> asList(new BigDecimal("1.6"), new BigDecimal("1.3"))); | |||
There was a problem hiding this comment.
CollQueryFactory suffers from https://stackoverflow.com/a/32294457/2104280.
This is technically not a breaking API change: users that already were on Java 8, struggled with the exact same issue in their own codebase already.
| @@ -48,17 +48,6 @@ | |||
| </dependency> | |||
|
|
|||
| <!-- backwards compatibility --> | |||
| <dependency> | |||
| <groupId>com.infradna.tool</groupId> | |||
There was a problem hiding this comment.
bridge-method-annotation is unmaintained and doesn't support Java 8 bytecode.
The bridge methods are also not needed anymore: its safe to remove backwards compatibility methods in a major release.
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.3</version> | ||
| <version>3.8.1</version> |
There was a problem hiding this comment.
This wasn't causing issues, but I don't think it hurts to keep this up-to-date for the best compatiblility.
| @@ -221,12 +223,12 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-assembly-plugin</artifactId> | |||
| <version>2.5.4</version> | |||
| <version>3.3.0</version> | |||
There was a problem hiding this comment.
This wasn't causing issues, but I don't think it hurts to keep this up-to-date for the best compatiblility.
jwgmeligmeyling
force-pushed
the
java-8
branch
4 times, most recently
from
d32706e
to
07f5cf4
Compare
jwgmeligmeyling
force-pushed
the
java-8
branch
from
07f5cf4
to
161d2b4
Compare
jwgmeligmeyling
force-pushed
the
java-8
branch
2 times, most recently
from
5dc49dc
to
091569e
Compare
Changelog
5.0.0
Breaking changes
New features
Fetchable#stream()which returns aStream<T>. Make sure that the returned stream is always closed to free up resources, for example using try-with-resources. It does not suffice to rely on a terminating operation on the stream for this (i.e.forEach,collect).Dependency updates
cglibto 3.3.0 for Java 8+ supportasmto 9.0 for Java 8+ supportorg.datanucleus:javax.jdoinstead ofjavax.jdo:jdo-api. Seems more widely used and also got more recently updated.Plans
Optional.Fetchable#streamFetchable#stream(in particular Hibernate and plain JPA)