Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix DB crashes while writing to multiple tables #3072

Merged
merged 15 commits into from
Mar 17, 2023
Merged

fix(core): fix DB crashes while writing to multiple tables #3072

merged 15 commits into from
Mar 17, 2023

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Mar 16, 2023

Should fix #3062

Other fixes:

  • commit WAL seqTxn with column add / remove transaction to prevent WAL table be suspended after standalone ALTER TABLE transaction.
  • fix lag size calculation for WAL apply

@ideoma ideoma marked this pull request as ready for review March 16, 2023 18:54
@ideoma ideoma mentioned this pull request Mar 16, 2023
Merged
@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior Core Related to storage, data type, etc. labels Mar 17, 2023
@puzpuzpuz puzpuzpuz self-requested a review March 17, 2023 07:52
@ideoma
Merge remote-tracking branch 'origin/master' into fix-wal-apply-error
2cebd36 
 Conflicts:
	core/src/test/java/io/questdb/griffin/wal/WalWriterFuzzTest.java
@puzpuzpuz puzpuzpuz self-requested a review March 17, 2023 09:53
puzpuzpuz
puzpuzpuz previously approved these changes Mar 17, 2023
View reviewed changes
@ideoma ideoma changed the title fix(core): fix DB crashes while writing to table fix(core): fix DB crashes while writing to multiple tables Mar 17, 2023
@ideoma
Copy link
Collaborator Author

ideoma commented Mar 17, 2023

There is a nontrivial lag calculation bug which is completely rewritten in #3053
I am closing this PR, it the changes will be merged to #3053

@ideoma ideoma closed this Mar 17, 2023
@ideoma
Copy link
Collaborator Author

ideoma commented Mar 17, 2023

Having thought of that, now that I know that the last fuzz failure test will be fixed in #3053, it still make sense to have this fix first.

@ideoma ideoma reopened this Mar 17, 2023
@ideoma
Copy link
Collaborator Author

ideoma commented Mar 17, 2023

[PR Coverage check]

😍 pass : 317 / 353 (89.80%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/TableWriter.java 274 310 88.39%
🔵 io/questdb/PropServerConfiguration.java 2 2 100.00%
🔵 io/questdb/griffin/engine/groupby/vect/GroupByNotKeyedVectorRecordCursorFactory.java 11 11 100.00%
🔵 io/questdb/tasks/O3CallbackTask.java 1 1 100.00%
🔵 io/questdb/cairo/DefaultCairoConfiguration.java 2 2 100.00%
🔵 io/questdb/cairo/O3CallbackJob.java 2 2 100.00%
🔵 io/questdb/griffin/engine/groupby/vect/GroupByJob.java 2 2 100.00%
🔵 io/questdb/tasks/O3CopyTask.java 1 1 100.00%
🔵 io/questdb/griffin/engine/groupby/vect/VectorAggregateEntry.java 15 15 100.00%
🔵 io/questdb/cairo/wal/ApplyWal2TableJob.java 2 2 100.00%
🔵 io/questdb/griffin/engine/groupby/vect/GroupByRecordCursorFactory.java 2 2 100.00%
🔵 io/questdb/cairo/pool/AbstractMultiTenantPool.java 2 2 100.00%
🔵 io/questdb/mp/SOUnboundedCountDownLatch.java 1 1 100.00%

@ideoma ideoma merged commit 657d245 into master Mar 17, 2023
@ideoma ideoma deleted the fix-wal-apply-error branch March 17, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

Assignees
No one assigned
Labels
Bug Incorrect or unexpected behavior Core Related to storage, data type, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Occasional SIGSEGV on 7.0.1
2 participants
@ideoma @puzpuzpuz