feat(sql): add DROP ALL TABLES #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bziobrowski
reviewed
Jun 6, 2023
bziobrowski
reviewed
Jun 6, 2023
marregui
changed the title
bziobrowski
approved these changes
Jun 27, 2023
…rt socket writer (#3529)
[PR Coverage check]😍 pass : 84 / 85 (98.82%) file detail
|
puzpuzpuz
reviewed
Jul 6, 2023
| // expected syntax: DROP TABLE [ IF EXISTS ] name [;] | ||
| CharSequence tok = SqlUtil.fetchNext(lexer); | ||
| if (tok == null || !SqlKeywords.isTableKeyword(tok)) { | ||
| return unknownDropStatement(executionContext, tok); |
There was a problem hiding this comment.
This change broke enterprise version as both the unknownDropStatement and unknownDropTableSuffix methods were used there. @marregui could you check DropTableTest there and fix it?
There was a problem hiding this comment.
I have created https://github.com/questdb/questdb-enterprise/pull/70 with a propossed fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New supported syntax:
Each table (with the exception of tables with prefix
sys.ortelemetry) is treated with the same semantics as:so that non existing table names do not break the statement execution.
In case of failure (table is busy), an exception is thrown to communicate back to the client, however the method is greedy in that it will try to delete all the tables in the list, and report at the end in case of any failure.