Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build broken between go1.21rc4 and go1.21.0 #4021

Closed
howardjohn opened this issue Aug 8, 2023 · 4 comments · Fixed by #4020
Closed

Build broken between go1.21rc4 and go1.21.0 #4021

howardjohn opened this issue Aug 8, 2023 · 4 comments · Fixed by #4020

Comments

@howardjohn
Copy link 

$ go1.21rc4 build ./internal/handshake
# No issues
$ go1.21.0 build ./internal/handshake
# github.com/quic-go/quic-go/internal/handshake
internal/handshake/crypto_setup.go:362:37: cannot use h.allow0RTT (variable of type bool) as tls.QUICSessionTicketOptions value in argument to h.conn.SendSessionTicket

This is on master version of quic-go
@howardjohn
Copy link
Author

Last minute change: golang/go@a915b999c9

@howardjohn
Copy link
Author

Fixed by https://github.com/quic-go/quic-go/pull/4020/files

@mohammed90 mohammed90 mentioned this issue Aug 8, 2023
Merged
@ericvn ericvn mentioned this issue Aug 8, 2023
Merged
@marten-seemann marten-seemann linked a pull request Aug 9, 2023 that will close this issue
fix compatibility with API breaking change in Go 1.21 #4020
Merged
@zbindenren
Copy link

Can you merge it and make a release? Go 1.21 was released.

@zbindenren zbindenren mentioned this issue Aug 9, 2023
Closed
@marten-seemann
Copy link
Member

v0.37.4 is released.

@M4tteoP M4tteoP mentioned this issue Aug 11, 2023
Closed
seiferma added a commit to seiferma/Docker_CaddyLego that referenced this issue Aug 12, 2023
@seiferma
use go 1.20
edef562 
fixes issue caused by quic-go/quic-go#4021
@Times-Z Times-Z mentioned this issue Aug 24, 2023
Closed
@luckykeeper luckykeeper mentioned this issue Sep 15, 2023
Closed
@bct bct mentioned this issue Sep 29, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix compatibility with API breaking change in Go 1.21 spideroak-inc/quic-go
3 participants
@howardjohn @marten-seemann @zbindenren