Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the version for integration tests using a command line flag #3782

Merged
merged 2 commits into from
May 1, 2023

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Apr 22, 2023

We've had a lot of loops over the supported versions in our self tests. This is annoying for multiple reasons:

  1. We always have to fill out the quic.Config to make sure that these versions are actually used.
  2. It creates a lot of indentation of the test code.
  3. Running the suite takes a long time, since all versions are tested. Most changes we make are not version-dependent though.

By setting the version as a command line parameter, we can still test all versions (mostly on CI), but just run using v1 locally.

This requires splitting out the version negotiation tests into a separate package.

@marten-seemann marten-seemann force-pushed the integration-tests-versions branch 2 times, most recently from 98d3992 to 2f0d560 Compare April 22, 2023 10:39
@marten-seemann marten-seemann marked this pull request as ready for review April 22, 2023 10:45
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #3782 (2b0a03a) into master (172123c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3782   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files         142      142           
  Lines       14089    14090    +1     
=======================================
+ Hits        11868    11869    +1     
  Misses       1801     1801           
  Partials      420      420           
Impacted Files Coverage Δ
http3/client.go 85.48% <100.00%> (+0.05%) ⬆️

@marten-seemann marten-seemann merged commit ea721c9 into master May 1, 2023
30 checks passed
@marten-seemann marten-seemann deleted the integration-tests-versions branch May 1, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants