put a context on a dial functions, remove Dial*Context, remove host parameter #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3785 +/- ##
==========================================
- Coverage 84.24% 84.23% -0.00%
==========================================
Files 142 142
Lines 14090 14075 -15
==========================================
- Hits 11869 11856 -13
+ Misses 1801 1799 -2
Partials 420 420
|
marten-seemann
force-pushed
the
integration-tests-versions
branch
3 times, most recently
from
9917126
to
41e09e0
Compare
marten-seemann
force-pushed
the
dial-context
branch
from
1ca1de5
to
8777355
Compare
lucas-clemente
approved these changes
May 1, 2023
marten-seemann
force-pushed
the
integration-tests-versions
branch
from
41e09e0
to
2b0a03a
Compare
* add a context to all Dial functions
* remove the explicit Dial{*}Context functions
marten-seemann
force-pushed
the
dial-context
branch
from
8777355
to
aee7706
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3782. Part of #3727.