accept overlapping stream data #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
==========================================
- Coverage 90.57% 90.54% -0.03%
==========================================
Files 78 78
Lines 5142 5168 +26
==========================================
+ Hits 4657 4679 +22
- Misses 310 312 +2
- Partials 175 177 +2
Continue to review full report at Codecov.
|
|
Don't trust @codecov-io here, nothing was changed in client.go. |
lucas-clemente
approved these changes
Feb 27, 2017
stream_frame_sorter.go
Outdated
| } | ||
|
|
||
| // fmt.Printf("Start Gap: %d to %d\n", gap.Value.Start, gap.Value.End) | ||
| // fmt.Printf("End Gap: %d to %d\n", endGap.Value.Start, endGap.Value.End) |
marten-seemann
force-pushed
the
streamframesorter
branch
2 times, most recently
from
2794298
to
14d6c8f
Compare
|
Done. Waiting with the merge until we resolve #456, to keep our CIs happy. |
marten-seemann
force-pushed
the
streamframesorter
branch
from
14d6c8f
to
e674016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408
Since we're still using the linked list, we should reopen #300.