Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Improvements for apps/Android/ImageClassification/build_apk.py #38

Closed
fangxingSR opened this issue May 7, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@fangxingSR
Copy link
Contributor

fangxingSR commented May 7, 2024

Describe the bug

There is an issue with build_apk.py: when only the qnnsdk and model_path are input, the model selection menu should not be printed using printmenu(), because the model will invariably be assigned the value of 'classification.tflite'.

I have modified the decision rule: the model selection menu will only be printed if neither model_name nor model_path has been provided.
It is suggested that line 45 be changed to:
if not args.model_name and not args.model_path:

@fangxingSR fangxingSR changed the title [BUG] Improvements to the functionality of apps/Android/ImageClassification/build_apk.py [BUG] Improvements for apps/Android/ImageClassification/build_apk.py May 7, 2024
@mestrona-3
Copy link

Hi @fangxingSR, thanks for reporting this issue. We'll look into this and provide an update here.

@mestrona-3 mestrona-3 added the bug Something isn't working label May 10, 2024
@fangxingSR
Copy link
Contributor Author

I created and submitted a branch to #41 . This submission aims to optimize the logic of the build_apk.py script and update the README.md file. I hope this contribution will bring positive benefits to the community and look forward to it being helpful to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants