Enhanced 'build_apk.py' logic & 'README.md' #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced 'build_apk.py' logic & 'README.md'.
There was an issue in 'build_apk.py': when only 'qnnsdk' and 'model_path' were provided as inputs, it incorrectly invoked the 'printmenu()' function to display a model selection menu, despite the model always being renamed to 'classification.tflite'. To address this, I adjusted the logic so that the model selection menu is only printed when neither 'model_name' nor 'model_path' is specified by the user. Specifically, I changed line 45 of 'build_apk.py' to read:
```
if not args.model_name and not args.model_path:
```
Additionally, I made several descriptive improvements to the 'README.md' file. Recognizing that newcomers primarily aim to compile and install the ImageClassification application, I included more concise and efficient instructions tailored to their needs, aiming to minimize their trial-and-error process and facilitate a smoother onboarding experience."
Signed-off-by: w <27848155+fangxingSR@users.noreply.github.com>
kory
approved these changes
May 9, 2024
|
Thank you! |
kory
reviewed
May 9, 2024
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| 1. Java, android-sdk and sdkmanager is already set at user's end | |||
| 2. User should have Linux QNN SDK in local machine. | |||
| 3. If models need to be downloaded during the execution of build_apk.py, qai-hub must be installed first according to the[ README.md in ai-hub-models](https://github.com/quic/ai-hub-models/blob/main/README.md). | |||
There was a problem hiding this comment.
Can you replace qui-hub with AI Hub Models
There was a problem hiding this comment.
Thank you for your correction. The document has been revised
kory
reviewed
May 9, 2024
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| 1. Java, android-sdk and sdkmanager is already set at user's end | |||
| 2. User should have Linux QNN SDK in local machine. | |||
| 3. If models need to be downloaded during the execution of build_apk.py, qai-hub must be installed first according to the[ README.md in ai-hub-models](https://github.com/quic/ai-hub-models/blob/main/README.md). | |||
There was a problem hiding this comment.
Could you also move the space before README.md outside of the link text. Thanks!
There was a problem hiding this comment.
This was my negligence, thank you for pointing out the mistake. The document has been revised
Replace qai-hub with AI Hub Models. Remove the leading space in the line starting with [ README.md...... Signed-off-by: w <27848155+fangxingSR@users.noreply.github.com>
Signed-off-by: w <27848155+fangxingSR@users.noreply.github.com>
|
Thanks! Your contribution is included in release 0.6.0, which is being pushed out today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced 'build_apk.py' logic & 'README.md'.