Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential for tick / cross emoji? #3

Open
ceeK opened this issue Mar 1, 2017 · 9 comments
Open

Potential for tick / cross emoji? #3

ceeK opened this issue Mar 1, 2017 · 9 comments

Comments

@ceeK
Copy link

ceeK commented Mar 1, 2017

I recall seeing this on Twitter awhile back and thinking it was cool.

It can look cleaner to use emoji for the test results in the timeline:

Just a thought!

@shaps80
Copy link
Member

shaps80 commented Mar 1, 2017

I considered this but in Playgrounds (particularly) on iPad I didn't want to have console output initially. So for me the 'traffic lights' are cleaner.

That said, I'm working on bringing in full Nimble atm -- so if it makes then I can imagine that being nice in the console output at least.

@ceeK
Copy link
Author

ceeK commented Mar 1, 2017

What I mean is replacing the traffic light colours with emoji strings to remove the RGB values. So still traffic lights?

screen shot 2017-03-01 at 11 28 22

Unless there is a technical limitation why strings aren't possible of course (or at least worse).

Arguably this could be less confusing to the new user than displaying R: 100, G: 0, B: 0 for test results.

@shaps80
Copy link
Member

shaps80 commented Mar 1, 2017

Ah I see... I hate those particular emoji haha but maybe you're right. I'll look into that. Will also check that iPad produces the same result.

@ceeK
Copy link
Author

ceeK commented Mar 1, 2017

If the demographic of iPad testing is to let people new to coding get into testing, the tick and cross could further reinforce the success / failure :)

Just a thought though!

@shaps80
Copy link
Member

shaps80 commented Mar 1, 2017

True. Although I hate those particular emoji's I also like that fact that these are unlikely to clash/cutter other output. E.g. if I am also outputting color values in my code. It can be somewhat confusing.

@shaps80 shaps80 added this to Inbox / Needs discussion in Prioritization Mar 1, 2017
@ceeK
Copy link
Author

ceeK commented Mar 1, 2017

For completeness I found my original inspiration for this ticket: https://github.com/Liquidsoul/XCTestPlayground

@shaps80
Copy link
Member

shaps80 commented Mar 3, 2017

Ok so @ceeK -- I don't like the clipping on those emoji so I've come up with an alternative.
I also think it brings MORE attention to failed tests and less attention to passing ones.
Thoughts?
screen shot 2017-03-03 at 17 45 40

@shaps80 shaps80 moved this from Inbox / Needs discussion to Backlog / Accepted work in Prioritization Mar 6, 2017
@chrisamanse
Copy link

+1 on the emojis. It also has better accessibility (color blindness).

@shaps80
Copy link
Member

shaps80 commented May 19, 2017

The issue with this has been that iPad doesn't show the emoji's unfortunately – but I will definitely include this for the Xcode builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Prioritization
Backlog / Accepted work
Development

No branches or pull requests

3 participants