Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HoloISO downloads #1067

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix HoloISO downloads #1067

merged 1 commit into from
Apr 17, 2024

Conversation

lj3954
Copy link
Contributor

@lj3954 lj3954 commented Apr 17, 2024 •
edited
Loading

Original HoloISO was discontinued, this replaces it with the new immutable version.

The user agent for macOS set here also was unnecessary and totally broken. That would set it to the macOS internetrecovery user agent only if the OS was not equal to macos, which is wrong, and curl's headers appear to
override the user agent flag so it's completely unnecessary. Therefore, I've removed that as well.

Fixes #1062

@zen0bit
Copy link
Contributor

zen0bit commented Apr 17, 2024 •
edited
Loading 

Downloading SteamOS HoloISO 1.1.6 : holoiso_beta_snapshot20240325.1158.39-InstallerBuild-20240401131732-x86_64.iso
curl: (35) OpenSSL/3.2.1: error:80000002:system library::No such file or directory

ERROR! Failed to download https://cd2.holoiso.ru.eu.org/holoiso-installer/holoiso_beta_snapshot20240325.1158.39-InstallerBuild-20240401131732-x86_64.iso with curl.
       Try deleting 'holoiso-1.1.6/holoiso_beta_snapshot20240325.1158.39-InstallerBuild-20240401131732-x86_64.iso' running 'quickget' again.

Maybe broken by this? #1063

@flexiondotorg flexiondotorg merged commit 6f88ffe into quickemu-project:master Apr 17, 2024
@zen0bit
Copy link
Contributor

zen0bit commented Apr 17, 2024

Don't work for me.

Forgot mention that @flexiondotorg

zen0bit
zen0bit reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@zen0bit zen0bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't work for me

@lj3954 lj3954 deleted the holoiso_fix branch April 20, 2024 05:34
@lj3954 lj3954 restored the holoiso_fix branch April 20, 2024 05:34
@lj3954 lj3954 deleted the holoiso_fix branch April 20, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zen0bit zen0bit zen0bit left review comments

@flexiondotorg flexiondotorg flexiondotorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: holoiso does not download
3 participants
@lj3954 @zen0bit @flexiondotorg