#874 - Fix failing to launch VMs from outside directory #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zen0bit
approved these changes
Dec 21, 2023
zen0bit
pushed a commit
to oSoWoSo/quickemu
that referenced
this pull request
Dec 23, 2023
zen0bit
pushed a commit
to oSoWoSo/quickemu
that referenced
this pull request
Apr 12, 2024
zen0bit
pushed a commit
to oSoWoSo/quickemu
that referenced
this pull request
Apr 12, 2024
zen0bit
pushed a commit
to oSoWoSo/quickemu
that referenced
this pull request
Apr 13, 2024
zen0bit
added a commit
to oSoWoSo/quickemu
that referenced
this pull request
Apr 13, 2024
zen0bit
added a commit
to oSoWoSo/quickemu
that referenced
this pull request
Apr 13, 2024
zen0bit
added a commit
to oSoWoSo/quickemu
that referenced
this pull request
Apr 13, 2024
zen0bit
added a commit
to oSoWoSo/quickemu
that referenced
this pull request
Apr 15, 2024
flexiondotorg
pushed a commit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The args array doesn't work properly when quotes are used, so the other fix I thought of (appending VM Path to every variable) wouldn't work if there's a space in the path. Changing directory isn't the best solution, but I can't think of any issues it would cause in this specific case.