-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newπ₯³year merge #892
Newπ₯³year merge #892
Conversation
--show-iso-url/-u --show-distro-homepage/-s Also slightly modified help message
* Fix quickget show-iso-url and test-iso-url creating unnecessary directory * Beautify output, add show-iso-url and test-iso-url for Windows (fully) and macOS (sorta) * (NON-FUNCTIONAL) macrecovery shell script. * Semi-functional (although incomplete) macrecovery shell script Rough draft. To be completed, cleaned up and simplified (very much so) hoping to merge into quickemu & replace the python macrecovery dependency. * macrecovery shell script now successfully downloads the image. TODO: Verification * Merged macrecovery functions into quickget. Chunkcheck (C) to replace macrecovery's image verification Chunkcheck written by MCJack123: https://gist.github.com/MCJack123/943eaca762730ca4b7ae460b731b68e7 * Replace C chunkcheck binary with the Python equivalent. Re-add python to dependencies. * force macOS guests to usually boot with core counts which are powers of 2; fix quickemu-project#865 * Add support for macOS Sonoma * Fix issue where script would be unable to find chunkcheck if installed system-wide * Update README verbiage * Add headers to web_get function; macOS can now be downloaded via aria2; clean up code & output * Add support for macOS Sonoma * Fix use of wrong operator (>) which touches a file * Small correction to README * macOS switched from wget to default downloader (aria2/wget) * Replace wget with cURL for downloading macOS chunklist file * Fix variable naming in generate_id function
* Add windows languages, many bugfixes Entering a release, edition, or OS with only part of a valid one will now throw an error, rather than attempting to download i.e. $quickget windows 1 > "ERROR! Windows 1 is not a supported release", rather than attempting to download a nonexistent ISO * Replace "languages" with "editions" to improve consistency * Remove unnecessary code, hardcode windows editions to not waste time * Add windows server, LTSC * Windows server requires IDE drive * Update Windows Guests section in README.md * Improve support for windows server Add back the language array, change stylization of languages in list
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
list, list_csv and list_json Not mentioned! Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Check pushed changes |
quickemu-project/quickemu#892 Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
Signed-off-by: zenobit <zenobit@disroot.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to think that one day the code will get tidied enough that we don't have to have all these shellcheck disablements. But if we don't turn off the hundreds of warnings, we can't see the errors, I suppose. Hope's spring is eternal ....
As a heads-up seemed okay, from the other day: I noticed that quickget Mageia is seriously out-of-date. We are offering ver 8 which went EOL last month and is no longer downloadable .... π edit: not downloadable from their html download page, that is PS also GhostBSD has new release 23.10.01 |
|
I haven't really explored GitHub actions as a tool. I have tended to see it as aimed more at enterprise level and left it be. You seem to have done well with it and Mega Lint certainly looks impressive. There are so many tests. Are all the languages that are being linted in use in quickemu? Or are there snippets are hiding in places? In general, I am a bit concerned about shellcheck being disabled left right and centre and then having claims made that the code is all good because it can now pass .... Personally, I would feel happier knowing that the new code is being usage tested to see that it actually does what it is meant to do and that it can do it in different usage scenarios. |
I wanna use output of linters and create review on PR. But so far not succesfully. This will be closed, other PRs in progres.. |
A lot...
quickget
Big refactoring
New feature:
quickget -i alpine
Output will look like this:
fold -s -w $(tput cols)
cut_1
instead ofcut -d' ' -f1
in HASH and some othersAdded again:
New distro:
Break changes:
Changes:
Fix:
Include changes from @lj3954, @DaffyDuke and me
Also our two big updates will no longer be needed, everything is included here. π₯Έ (hopefully) Check pls
Mostly should work as expected.
Need more testing edge cases.
And finish download_iso_to
PS: Maybe I forgot mention some change...
Happy new year
π