-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
including benchmarking code for QFJ within another module in the code base #576
Comments
Sounds like a sensible idea. Are you aware of anything that could also trigger a github action in case there is a regression? Or will the build just fail? |
Running microbenchmarks reliably in GitHub Actions is probably hard, as they are very sensitive to their runtime environment. However, just having the microbenchmarks in an executable Maven module is itself a good goal, even if it is not part of the CI. For Philadelphia, I run the microbenchmarks manually towards the end of the release cycle. JMH provides machine-readable output formats, such as JSON, if you pass it the |
@chrjohn now I think about it it might be difficult to come up performance regression as we need to come up with sensible assertion for the benchmark. But I totally agree with @jvirtanen , if we have executable maven module based on JMH we can provide way for contributors to manually benchmark them. Can we take this as a feature, I'd like to make a PR on this. |
The assertion probably would be that after each commit the performance should not decrease. |
hi @chrjohn / @jvirtanen I made PR for quickfixj-per-test , kindly provide your feedback |
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Provide additional maven module to include all performance regression.
Any code changes would additionally have to pass the performance regression.
Example , having this benchmark code from @chrjohn, within code base is useful.
#559
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: