Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarking code to check for performance regressions #582

Merged
merged 16 commits into from
Jul 1, 2024
Merged

Benchmarking code to check for performance regressions #582

merged 16 commits into from
Jul 1, 2024

Conversation

busy-spin
Copy link
Contributor

@busy-spin busy-spin commented Dec 4, 2022 •
edited by chrjohn
Loading

Fixes #576

@busy-spin busy-spin mentioned this pull request Dec 4, 2022
Closed
@chrjohn
Copy link
Member

chrjohn commented Dec 12, 2022

Thanks for the PR @isurudevj , would it be possible to add a form of README.md or similar to show how the tests can be run?

@busy-spin
Copy link
Contributor Author

Thanks for the PR @isurudevj , would it be possible to add a form of README.md or similar to show how the tests can be run?

hi @chrjohn added README.md file.

@chrjohn chrjohn changed the title Bugfix/issue 576 perf regression Benchmarking code to check for performance regressions Dec 19, 2022
@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Dec 12, 2023
@chrjohn chrjohn mentioned this pull request Dec 30, 2023
Merged
@busy-spin
Copy link
Contributor Author

hi @chrjohn

It was quiet a break between our last conversation. I have fixed the merge conflicts.
Kindly see if you can review and provide me feedback on new perf testing module.

@chrjohn
Copy link
Member

chrjohn commented Jun 18, 2024

Hi @busy-spin , thank you, looks good to me. 👍 Will merge in due course.

@chrjohn chrjohn merged commit 884fb77 into quickfix-j:master Jul 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrjohn chrjohn chrjohn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
QFJ 3.0.0
Development

Successfully merging this pull request may close these issues.

including benchmarking code for QFJ within another module in the code base
2 participants
@busy-spin @chrjohn