Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support timeout on ssl connection #347

Closed
ijufumi opened this issue Dec 13, 2018 · 0 comments
Closed

Support timeout on ssl connection #347

ijufumi opened this issue Dec 13, 2018 · 0 comments

Comments

@ijufumi
Copy link
Contributor

ijufumi commented Dec 13, 2018

Hi,

When TLS handshake hangs, handleConnection process is waiting so long.
reference: golang/go#17708

I would like to setting timeout on ssl connection.
change quickfix/initiator.go line 139 to

tlsConn, err := tls.DialWithDialer(&net.Dialer{Timeout: 15 * time.Second}, "tcp", address, tlsConfig)

What do you think about it?
@ijufumi ijufumi mentioned this issue Dec 14, 2018
Merged
cbusbey added a commit that referenced this issue Dec 19, 2018
@cbusbey
Merge pull request #348 from ijufumi/master
379deb8 
Support timeout on ssl connection #347
@cbusbey cbusbey closed this as completed Dec 19, 2018
@ijufumi ijufumi mentioned this issue Jan 7, 2019
Closed
level2player pushed a commit to longbridgeapp/quickfix that referenced this issue Jul 19, 2022
@cbusbey
Merge pull request quickfixgo#348 from ijufumi/master
57eb17c 
Support timeout on ssl connection quickfixgo#347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbusbey @ijufumi