fix proto-gen after ibc v6.3.x upgrade #1499
Conversation
joe-bowman
requested review from
faddat,
minhngoc274 and
tuantran1702
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (2)
You can disable this status message by setting the WalkthroughThis update brings a version bump in the Makefile for BUF, minor formatting refinements in the README.md for better readability and clarity, and a Dockerfile adjustment that updates the base image to a newer Alpine version. These changes enhance tool compatibility and improve documentation presentation. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (4)
README.md (4)
Line range hint
11-11: Consider adding a possessive apostrophe: "users' voting rights."- stripping away users voting rights + stripping away users' voting rightsThis change will correct the grammar, making the sentence clearer and more professional.
Line range hint
12-12: Consider using American English for consistency: "incentivize" and "decentralization."- incentivise decentralisation + incentivize decentralizationThis change aligns the spelling with American English, which is typically used in technical documentation, enhancing consistency across the document.
Line range hint
54-54: Consider reducing the number of exclamation marks.Reducing the use of exclamation marks in professional documentation can help maintain a more formal tone. Consider revising to a single exclamation mark or none.
Line range hint
66-66: Consider adding a comma and the article "a" for grammatical correctness.- For subsequent tests run the following if you want to start with fresh state + For subsequent tests, run the following if you want to start with a fresh stateThis change adds necessary punctuation and articles to make the instructions clearer and grammatically correct.
|
This pull request has been deployed to Vercel.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1499 +/- ##
=======================================
Coverage 63.13% 63.13%
=======================================
Files 192 192
Lines 13458 13458
=======================================
Hits 8497 8497
Misses 4151 4151
Partials 810 810
Flags with carried forward coverage won't be shown. Click here to find out more. |
1. Summary
Fixes
make proto-genpost ibc-go upgrade.We use buf for generating protobuf files.
The definitions pushed to buf by the ibc-go team are incorrect, and use the v8+ file path, with just the version changed to v6, causing all proto-gen attempts to fail.
I published to buf.build/joe-bowman/ibc the v6.3.1 protobuf definitions, updated buf.yaml, recreated the lockfile and now
make proto-genruns sweetly.Summary by CodeRabbit
BUF_VERSIONto1.31.0to ensure compatibility and performance improvements.golang:1.22.2-alpine3.19for enhanced security and stability.