fix: update skip / SEO #1654
fix: update skip / SEO #1654
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate limit exceeded@chalabi2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 27 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughRecent updates to the Quicksilver Zone's web UI encompass significant improvements in type specifications, expanded chain support, metadata enrichments for SEO and social media sharing, and structured data enhancements. Key changes include a transition to specific Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
web-ui/components/wallet-button.tsx (1)
Line range hint
7-7: Rename theErrorcomponent to avoid shadowing the globalErrorobject.- import { Error } from '@/components'; + import { CustomError as Error } from '@/components';This change will prevent potential confusion and bugs related to the global
Errorobject.web-ui/components/Assets/modals/rewardsModal.tsx (2)
Line range hint
415-415: Use self-closing tags for JSX elements without children.- <ModalFooter></ModalFooter> + <ModalFooter />This change adheres to best practices in JSX and improves code readability.
Line range hint
322-322: Avoid using array indices as keys in React lists.- {tokenDetails.map((detail, index) => ( - <Tr key={index}> + {tokenDetails.map((detail) => ( + <Tr key={detail.id}> // Assuming `detail` has a unique `id` propertyUsing indices as keys can lead to issues with component state and performance if the order of items changes.
web-ui/components/Staking/modals/stakingProcessModal.tsx (2)
Line range hint
235-235: Use the exponentiation operator for better readability and performance.- let numericAmount = BigInt(Math.floor(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6')))); + let numericAmount = BigInt(Math.floor(parsedAmount * 10 ** Number(zone?.decimals ?? '6')));
Line range hint
235-235: Consider using the exponentiation operator for better readability.- let numericAmount = BigInt(Math.floor(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6')))); + let numericAmount = BigInt(Math.floor(parsedAmount * 10 ** Number(zone?.decimals ?? '6')));
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- web-ui/components/Assets/modals/rewardsModal.tsx (5 hunks)
- web-ui/components/Staking/modals/stakingProcessModal.tsx (1 hunks)
- web-ui/components/wallet-button.tsx (1 hunks)
- web-ui/hooks/useSkipExecute.ts (1 hunks)
- web-ui/package.json (1 hunks)
Additional context used
Biome
web-ui/components/wallet-button.tsx
[error] 7-7: Do not shadow the global "Error" property. (lint/suspicious/noShadowRestrictedNames)
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
web-ui/components/Assets/modals/rewardsModal.tsx
[error] 415-415: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing. (lint/style/useSelfClosingElements)
Unsafe fix: Use a SelfClosingElement instead
[error] 322-322: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.web-ui/components/Staking/modals/stakingProcessModal.tsx
[error] 235-235: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator)
Unsafe fix: Use the '**' operator instead of 'Math.pow'.
Additional comments not posted (6)
web-ui/components/wallet-button.tsx (1)
18-31: Added new chains to theuseChainshook.This update aligns with the PR's objective to support additional chains. Ensure that these chains are properly configured in the backend and tested.
web-ui/package.json (1)
34-34: Updated@skip-router/coreto version5.0.0.Ensure that this major version update is compatible with the rest of the project dependencies and that all functionalities relying on this package are thoroughly tested.
web-ui/hooks/useSkipExecute.ts (1)
7-10: Improved type safety by definingUserAddressinterface and updatingexecuteRouteto use it.This change enhances code readability and safety by ensuring that
userAddressesis strictly typed. It's a good practice to continue using explicit types to prevent runtime errors and improve maintainability.Also applies to: 19-19
web-ui/components/Assets/modals/rewardsModal.tsx (1)
45-57: Expanded thechainsarray and added a helper functiongetOrderedAddresses.These changes support the PR's objective to handle more chains and improve the address handling logic. Ensure that the new chains are properly integrated and tested.
Also applies to: 150-159
web-ui/components/Staking/modals/stakingProcessModal.tsx (2)
Line range hint
1-300: The usage of Chakra UI components is consistent and well-implemented.
258-258: Consider using the exponentiation operator for better readability.- let numericAmount = BigInt(Math.floor(parsedAmount * Math.pow(10, Number(zone?.decimals ?? '6')))); + let numericAmount = BigInt(Math.floor(parsedAmount * 10 ** Number(zone?.decimals ?? '6')));Likely invalid or redundant comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
- Coverage 63.61% 63.60% -0.01%
==========================================
Files 194 196 +2
Lines 13771 13779 +8
==========================================
+ Hits 8760 8764 +4
- Misses 4154 4158 +4
Partials 857 857
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@joe-bowman I added better head tags for SEO alongside the skip api fixes. Can you please review them for each of the pages, (staking, assets, defi, governance) it is at the top of each page in between the tags. Things to review would include descriptions and such. |
There was a problem hiding this comment.
Actionable comments posted: 5
Outside diff range and nitpick comments (4)
web-ui/pages/assets.tsx (2)
Line range hint
169-169: ReplacehasOwnPropertywithObject.hasOwn.- if (APYs.hasOwnProperty(chainId)) + if (Object.hasOwn(APYs, chainId))
Line range hint
371-371: JSX elements without children should be self-closing.- <Box h="40px"></Box> + <Box h="40px" />web-ui/pages/staking/[chainId]/[valoperAddress].tsx (2)
Line range hint
224-224: Use the exponentiation operator for better readability and performance.- const smallestUnitAmount = numericAmount * Math.pow(10, 6); + const smallestUnitAmount = numericAmount * 10**6;
Line range hint
490-490: ReplaceisNaNwithNumber.isNaNfor type-safe checks.- if (isNaN(inputValue) || inputValue <= 0) { + if (Number.isNaN(inputValue) || inputValue <= 0) {Also applies to: 656-656
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- web-ui/hooks/useSkipExecute.ts (2 hunks)
- web-ui/pages/about.tsx (1 hunks)
- web-ui/pages/assets.tsx (1 hunks)
- web-ui/pages/defi.tsx (1 hunks)
- web-ui/pages/governance.tsx (1 hunks)
- web-ui/pages/privacy-policy.tsx (1 hunks)
- web-ui/pages/staking/[chainId]/[valoperAddress].tsx (1 hunks)
- web-ui/pages/staking/index.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- web-ui/hooks/useSkipExecute.ts
Additional context used
Biome
web-ui/pages/assets.tsx
[error] 169-169: Do not access Object.prototype method 'hasOwnProperty' from target object. (lint/suspicious/noPrototypeBuiltins)
It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.
[error] 371-371: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing. (lint/style/useSelfClosingElements)
Unsafe fix: Use a SelfClosingElement instead
web-ui/pages/staking/[chainId]/[valoperAddress].tsx
[error] 224-224: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator)
Unsafe fix: Use the '**' operator instead of 'Math.pow'.
[error] 490-490: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead. (lint/suspicious/noGlobalIsNan)
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.
[error] 656-656: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead. (lint/suspicious/noGlobalIsNan)
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.
Additional comments not posted (6)
web-ui/pages/defi.tsx (1)
30-47: Validate structured data for SEO.Please ensure that the structured data in the JSON-LD script is valid and optimized for SEO.
web-ui/pages/about.tsx (1)
44-61: Validate structured data for SEO.Please ensure that the structured data in the JSON-LD script is valid and optimized for SEO.
web-ui/pages/staking/index.tsx (1)
85-102: Validate structured data for SEO.Please ensure that the structured data in the JSON-LD script is valid and optimized for SEO.
web-ui/pages/privacy-policy.tsx (1)
18-61: SEO and metadata enhancements look comprehensive and well-implemented.Ensure that the content accurately reflects the page's purpose and complies with SEO best practices.
web-ui/pages/assets.tsx (1)
201-244: SEO and metadata enhancements look comprehensive and well-implemented.Ensure that the content accurately reflects the page's purpose and complies with SEO best practices.
web-ui/pages/staking/[chainId]/[valoperAddress].tsx (1)
79-122: SEO and metadata enhancements look comprehensive and well-implemented.Ensure that the content accurately reflects the page's purpose and complies with SEO best practices.
There was a problem hiding this comment.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web-ui/components/Assets/modals/rewardsModal.tsx (9 hunks)
Additional context used
Biome
web-ui/components/Assets/modals/rewardsModal.tsx
[error] 460-460: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing. (lint/style/useSelfClosingElements)
Unsafe fix: Use a SelfClosingElement instead
[error] 368-368: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.
Additional comments not posted (6)
web-ui/components/Assets/modals/rewardsModal.tsx (6)
34-34: Ensure the import ofUserAddressis utilized properly throughout the component.
46-58: The addition of new chains to theuseChainshook enhances the functionality of the modal by supporting more blockchain networks.
114-114: Filtering out native quick tokens is a crucial operation for ensuring that only relevant tokens are processed. Good implementation.
180-190: TheformatTokenNamefunction is well-implemented for formatting token names based on their origin. This enhances readability and user experience.
352-359: Refactor to use self-closing elements for better style and performance. Also, avoid using array indices as keys in React lists to prevent issues with re-rendering and state management.- <Checkbox isChecked={selectAll} onChange={handleSelectAllChange} colorScheme="complimentary" borderColor="complimentary.900" /> + <Checkbox isChecked={selectAll} onChange={handleSelectAllChange} colorScheme="complimentary" borderColor="complimentary.900" /> - <Checkbox isChecked={selectedAssets.includes(detail?.denom ?? '')} onChange={() => handleCheckboxChange(detail?.denom ?? '')} colorScheme="complimentary" borderColor="complimentary.900" /> + <Checkbox isChecked={selectedAssets.includes(detail?.denom ?? '')} onChange={() => handleCheckboxChange(detail?.denom ?? '')} colorScheme="complimentary" borderColor="complimentary.900" />Also applies to: 369-375
Likely invalid or redundant comment.
196-208: Properly managing addresses for multiple chains is crucial. Ensure that all addresses are defined to avoid runtime errors.Verification successful
The verification process confirms that all chain addresses are properly defined and not null in the specified file.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all chain addresses are defined and not null. # Test: Search for the chain address usage. Expect: No occurrences of undefined or null addresses. rg --type typescript $'chains.[a-zA-Z]+.address ?? \'\'' web-ui/components/Assets/modals/rewardsModal.tsxLength of output: 145
Script:
#!/bin/bash # Description: Verify that all chain addresses are defined and not null. # Test: Search for the chain address usage. Expect: No occurrences of undefined or null addresses. rg --type ts $'chains.[a-zA-Z]+.address ?? \'\'' web-ui/components/Assets/modals/rewardsModal.tsxLength of output: 102
Script:
#!/bin/bash # Description: Verify that no chain addresses are undefined or null. # Test: Search for any instances of undefined or null addresses. rg --type ts 'chains\.[a-zA-Z]+\.(address\s*=\s*undefined|address\s*=\s*null)' web-ui/components/Assets/modals/rewardsModal.tsxLength of output: 129
There was a problem hiding this comment.
Actionable comments posted: 4
Outside diff range and nitpick comments (1)
web-ui/components/Assets/modals/rewardsModal.tsx (1)
Line range hint
462-462: JSX elements without children should be marked as self-closing. This is a minor style improvement.- <ModalFooter></ModalFooter> + <ModalFooter />
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web-ui/components/Assets/modals/rewardsModal.tsx (9 hunks)
Additional context used
Biome
web-ui/components/Assets/modals/rewardsModal.tsx
[error] 462-462: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing. (lint/style/useSelfClosingElements)
Unsafe fix: Use a SelfClosingElement instead
[error] 368-368: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.
Additional comments not posted (1)
web-ui/components/Assets/modals/rewardsModal.tsx (1)
34-34: Ensure theUserAddresstype is correctly imported and utilized throughout the component.
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
web-ui/components/wallet-button.tsx (1)
Line range hint
7-7: Consider renaming theErrorcomponent to avoid shadowing the global JavaScriptErrorobject.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- web-ui/components/Assets/modals/rewardsModal.tsx (10 hunks)
- web-ui/components/wallet-button.tsx (1 hunks)
- web-ui/pages/about.tsx (1 hunks)
- web-ui/pages/defi.tsx (1 hunks)
- web-ui/pages/governance.tsx (1 hunks)
- web-ui/pages/staking/index.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- web-ui/pages/about.tsx
- web-ui/pages/defi.tsx
- web-ui/pages/governance.tsx
- web-ui/pages/staking/index.tsx
Additional context used
Biome
web-ui/components/wallet-button.tsx
[error] 7-7: Do not shadow the global "Error" property. (lint/suspicious/noShadowRestrictedNames)
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
Additional comments not posted (2)
web-ui/components/wallet-button.tsx (1)
18-33: Ensure the added chains are correctly integrated with the rest of the application.web-ui/components/Assets/modals/rewardsModal.tsx (1)
31-31: Review the integration of the added chains and the new asset selection logic.Also applies to: 34-34, 46-60, 83-107, 118-118, 172-182, 201-215, 218-223, 226-226, 228-232, 258-260, 283-287, 361-367, 377-397, 428-428
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
web-ui/pages/assets.tsx (1)
Line range hint
169-169: ReplacehasOwnPropertywithObject.hasOwn.- APYs && APYs.hasOwnProperty(chainId) ? APYs[chainId] : 0; + APYs && Object.hasOwn(APYs, chainId) ? APYs[chainId] : 0;Using
Object.hasOwn()instead ofObject.prototype.hasOwnProperty.call()avoids potential issues with properties that override the default behavior.web-ui/pages/staking/[chainId]/[valoperAddress].tsx (1)
Line range hint
510-510: ReplaceisNaNwithNumber.isNaNfor type-safe checks.- if (isNaN(inputValue) || inputValue <= 0) { + if (Number.isNaN(inputValue) || inputValue <= 0) {Using
Number.isNaNprovides a type-safe way to check for NaN values, avoiding the coercion behavior of the globalisNaN.Also applies to: 676-676
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
web-ui/public/img/banner.jpgis excluded by!**/*.jpg
Files selected for processing (5)
- web-ui/pages/about.tsx (1 hunks)
- web-ui/pages/assets.tsx (1 hunks)
- web-ui/pages/defi.tsx (1 hunks)
- web-ui/pages/staking/[chainId]/[valoperAddress].tsx (3 hunks)
- web-ui/pages/staking/index.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- web-ui/pages/about.tsx
- web-ui/pages/defi.tsx
- web-ui/pages/staking/index.tsx
Additional context used
Biome
web-ui/pages/assets.tsx
[error] 169-169: Do not access Object.prototype method 'hasOwnProperty' from target object. (lint/suspicious/noPrototypeBuiltins)
It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.web-ui/pages/staking/[chainId]/[valoperAddress].tsx
[error] 244-244: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator)
Unsafe fix: Use the '**' operator instead of 'Math.pow'.
[error] 510-510: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead. (lint/suspicious/noGlobalIsNan)
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.
[error] 676-676: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead. (lint/suspicious/noGlobalIsNan)
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.
Additional comments not posted (3)
web-ui/pages/assets.tsx (1)
201-223: Ensure the SEO tags are fully reflective of the intended metadata.The SEO enhancements with meta tags, Open Graph, and Twitter cards are well-implemented and should improve the page's visibility and shareability on social networks.
web-ui/pages/staking/[chainId]/[valoperAddress].tsx (2)
105-123: Ensure the SEO tags are fully reflective of the intended metadata.The SEO enhancements with meta tags, Open Graph, and Twitter cards are well-implemented and should improve the page's visibility and shareability on social networks.
Line range hint
244-244: Use the exponentiation operator for clarity and conciseness.
[REFACTOR_SUGGESTion]- const smallestUnitAmount = numericAmount * Math.pow(10, 6); + const smallestUnitAmount = numericAmount * 10**6;The exponentiation operator (
**) is preferred for readability and is part of modern JavaScript best practices.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
web-ui/pages/assets.tsx (1)
Line range hint
169-169: ReplacehasOwnPropertywithObject.hasOwn.- if (APYs.hasOwnProperty(chainId)) { + if (Object.hasOwn(APYs, chainId)) {Using
Object.hasOwn()is recommended overhasOwnProperty()as it is available on the prototype chain and prevents potential issues with objects that have modified prototypes.web-ui/pages/staking/[chainId]/[valoperAddress].tsx (2)
Line range hint
244-244: Use the exponentiation operator for clarity and modern JavaScript practices.- const smallestUnitAmount = numericAmount * Math.pow(10, 6); + const smallestUnitAmount = numericAmount * (10 ** 6);The exponentiation operator (
**) is more readable and idiomatic in modern JavaScript thanMath.pow.
Line range hint
510-510: ReplaceisNaNwithNumber.isNaNfor type-safe checks.- if (isNaN(inputValue) || inputValue <= 0) { + if (Number.isNaN(inputValue) || inputValue <= 0) {
Number.isNaN()provides a safer, more accurate check as it does not coerce the type, unlike the globalisNaNfunction.Also applies to: 676-676
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- web-ui/pages/about.tsx (1 hunks)
- web-ui/pages/assets.tsx (1 hunks)
- web-ui/pages/defi.tsx (1 hunks)
- web-ui/pages/staking/[chainId]/[valoperAddress].tsx (3 hunks)
- web-ui/pages/staking/index.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- web-ui/pages/about.tsx
- web-ui/pages/defi.tsx
- web-ui/pages/staking/index.tsx
Additional context used
Biome
web-ui/pages/assets.tsx
[error] 169-169: Do not access Object.prototype method 'hasOwnProperty' from target object. (lint/suspicious/noPrototypeBuiltins)
It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.web-ui/pages/staking/[chainId]/[valoperAddress].tsx
[error] 244-244: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator)
Unsafe fix: Use the '**' operator instead of 'Math.pow'.
[error] 510-510: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead. (lint/suspicious/noGlobalIsNan)
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.
[error] 676-676: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead. (lint/suspicious/noGlobalIsNan)
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.
Additional comments not posted (2)
web-ui/pages/assets.tsx (1)
201-241: Ensure SEO and social media metadata is accurate and consistent.The updated SEO and social media metadata in the
<Head>tags are comprehensive and aligned with best practices for enhancing search visibility and social media presentation.web-ui/pages/staking/[chainId]/[valoperAddress].tsx (1)
105-142: Ensure SEO and social media metadata is accurate and consistent.The dynamic generation of SEO and social media metadata based on the chain name and validator address is correctly implemented, enhancing the page's visibility and shareability.
|
This pull request has been deployed to Vercel.
|
1. Summary
Fixes the unwinder for sending rewards to osmosis or their parent chains
Adds better SEO Meta tags & banner images
2.Type of change
3. Implementation details
Upgreaded the skip api to v5 and changed the way user addresses are mapped to the skip execution hook
Summary by CodeRabbit
New Features
RewardsModalcomponent with improved address handling, error management, and asset selection features.Bug Fixes
RewardsModalcomponent to prevent execution issues with undefined addresses.Enhancements
useSkipExecutefunction to expect an array ofUserAddressobjects, improving type safety and consistency.WalletButtoncomponent.