Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single modifier activation not working on 1.2.0 #1712

Closed
D-elias opened this issue Dec 10, 2013 · 7 comments · Fixed by #1723
Closed

Single modifier activation not working on 1.2.0 #1712

D-elias opened this issue Dec 10, 2013 · 7 comments · Fixed by #1723
Labels

Comments

@D-elias
Copy link

@D-elias D-elias commented Dec 10, 2013

I have the single modifier key set to "Shift". It works fine to activate QS on 1.1.3 but not on the newest 1.2.0

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 10, 2013

Can you please tell us:

  • Which app in particular this does/doesn’t work in (or maybe just ‘all’)
  • Your OS version
  • If any of the other single modifier options work (ctrl, cmd etc)
  • What happens if you change the hotkey settings (modifier, number of times) in the prefs, then change them back

On 10 Rhag 2013, at 21:30, D-elias notifications@github.com wrote:

I have the single modifier key set to "Shift". It works fine to activate QS on 1.1.3 but not on the newest 1.2.0


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member

@skurfer skurfer commented Dec 10, 2013

For what it’s worth, I can’t get it to fail with any key, with or without a restart.

But I will add…

It seems I have to hit the modifier twice on occasion. This seems to only happen after switching apps, but nowhere near every time. I’ve been seeing this for months but just now discovered something additional: Single-modifier always seems to work immediately after switching apps via the mouse or a trackpad swipe, but after switching with the keyboard (⌘⇥), it has to be hit twice. After that, it will work until you switch apps again.

Does that describe your problem, or is it not working at all?

@D-elias
Copy link
Author

@D-elias D-elias commented Dec 10, 2013

Thanks for the solution. I changed it to "double Shift" and it worked, then back to single and it stopped again. Switching it from control then back to Shift did the trick. All is working now.

@D-elias D-elias closed this as completed Dec 10, 2013
@skurfer
Copy link
Member

@skurfer skurfer commented Dec 10, 2013

OK. I’ll open a separate issue about what I described now that I’ve finally figured out how to reproduce it.

@D-elias D-elias reopened this Dec 12, 2013
@D-elias
Copy link
Author

@D-elias D-elias commented Dec 12, 2013

The single/double shift and other single modifiers only work on the left side of the keyboard. The right shift and others on the right side of the keyboard are not working to launch QS. This is on the both the bluetooth and internal keyboards after a restart and reseting/changing the preferences. This problem is global on OSX 10.9. It completely goes away when I run the older 1.1.3

@skurfer
Copy link
Member

@skurfer skurfer commented Dec 12, 2013

The single/double shift and other single modifiers only work on the left side of the keyboard.

Confirmed.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 14, 2013

Yep, if you look at the top of QSModifierKeyEvents.m you’ll see only the left hand keys are defined.

Not sure of the best way about going about it, maybe we’ll need to re-gut how it works :(

P.S. I’m away from internet atm hence my radio silence

On 12 Rhag 2013, at 21:39, Rob McBroom notifications@github.com wrote:

The single/double shift and other single modifiers only work on the left side of the keyboard.

Confirmed.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants