URL Extractor updates #2005
Merged
URL Extractor updates #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only reason I can think to ignore anchors is because of noise? |
|
Maybe. I’ll try some real-world examples, but digging through noise quickly is sort of our specialty around here. 😃 |
|
This is just python and it's all pretty simple. I think this can be rebased and merged no problem. |
|
Shouldn’t need a rebase, should it? |
skurfer
added a commit
that referenced
this pull request
Aug 1, 2015
|
Nope, cool On Saturday, 1 August 2015, Rob McBroom notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing huge. I was writing a blog post for work on Beautiful Soup and was looking over this script, finding things I now don’t like. 😃
The only behavioral difference is that it now includes links to places on the same page (like
#this). I can’t remember why they were ever skipped. Anyone?