Little things

[skurfer]

In true @pjrobertson style, here are some small unrelated fixes for things that were bugging me. :-)

1. The status (like "1 of 13") at the bottom of the results list would only update if the selection changed. So if you type additional characters and the previously selected object still matched, the list would get shorter, but the status wouldn't reflect that.
2. A string like "mailto:foo@some.tld" would get "http://mailto:foo@some.tld" stored for its URL type. My fix for this feels a little hacky (since there's another test for "mailto:" right after), but it works.
3. If the last thing you had in the first pane was a web search, re-invoking the interface would show the search string small and shifted to the bottom (because name was blank, but details weren't). I gave the name a value in this situation. I'm not sure why it shouldn't have had one all along.

[tiennou]

Looks good.

[pjrobertson]

Just my small comment on 0f7ab13

[pjrobertson]

Could you fix a few warnings whilst you're at it?

• Remove - (BOOL)tableView:(NSTableView *)aTableView rowIsSeparator:(NSInteger)rowIndex; from QSCatalogPrefPane.h (incomplete implementation)
• Fix the warning in QSProxyObject.m:L156
• fix the 'copy' warnings about some lproj files being UTF-16 and not UTF-8

I'm happy to do so if you shotgun not ;-)

[skurfer]

Closing this down. I pushed the branch to the main QS repo. Make your changes and open another pull request. (I'm willing to do it, but don't have time.)

[pjrobertson]

K, cheers :)