-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh the third pane when using triggers #1587
Conversation
Cool, I'll test it later. Looks like it's better at making trigger interface activation more like normal activation On 4 Medi 2013, at 04:14, Rob McBroom notifications@github.com wrote:
|
Since you're obviously awake, if you have a few minutes to look at this (and assuming it's all good), we can get the next pre-release out. I'm thinking that will be the final one as well, but we can wait until the T-shirt thing is sorted out before we throw the switch. I can also then merge |
I went to sleep just before you sent this :P I'll look this morning, I have a bit of downtime. On 4 Medi 2013, at 22:43, Rob McBroom notifications@github.com wrote:
|
I'm still a little worried we might be missing something. If you look at the only other place that calls (That was my reasoning behind just saying the action object had changed - I was worried we would never be able to replicate everything that call does. Perhaps replacing your added line with a notification post for |
But seems to work fine of course. |
It looks like all that does is show or hide the third pane. Since we’re addressing the case where no selections have changed, it should already be in the right state (and it seems to work in practice). You think?
If you check, there’s only one place observing that notification and it’s |
Refresh the third pane when using triggers
I think that pretty much answers that :) |
This fixes the same bug as #1582, but I think it's a little cleaner than claiming the search object changed (when it didn't) just to trigger a known side-effect. I'm not convinced I've tested every use case, but it seems to fix the bug without adding any.