Validate the 'Show source in catalog' action so it's only available for objects actually in the catalog

[pjrobertson]

A nice bug for you all here:

• Enable the 'Show source in catalog' action
• type any text in the 1st pane "hello123" (or browse to a file you know isn't in your catalog)
• Tab to the 2nd pane and note that 'show source in catalog' is a possible action
• Perform the action, and watch QS open the catalog prefs then crash :)

This change:

• Adds a 'validatesObjects:YES' bool to the action in the Info.plist (sorry for it looking like everything got changed)
• checks whether the dObject is in the catalog in the validActionsForDirectObject method and enables the action depending on the result

[skurfer]

Nasty merge conflict. I ended up just pasting the entire existing file over the contents of the conflicted file (in a text editor), then manually adding the new setting. :-)

[pjrobertson]

It's only a tiny change. I'll close this and try to edit the Info.plist without modifying everything.

[skurfer]

OK. Maybe (after this is done), we should open all the plists, let Xcode rewrite them, then commit the new versions. Such a thing would need to be open and merged within hours (or maybe one of us should just commit it directly) so it doesn’t lead to more conflicts. I always end up changing them in TextMate because of issues like this.

[pjrobertson]

OK. Maybe (after this is done), we should open all the plists, let Xcode
rewrite them, then commit the new versions. Such a thing would need to be
open and merged within hours (or maybe one of us should just commit it
directly) so it doesnt lead to more conflicts. I always end up changing
them in TextMate because of issues like this.

I'm in the process of doing this :)
Changing the file type to 'Info plist' seems to do the trick. Once the GH
stuffs sorted, I'll submit a pull request for all of that.

On 3 February 2012 17:48, Rob McBroom <
reply@reply.github.com

wrote:

OK. Maybe (after this is done), we should open all the plists, let Xcode
rewrite them, then commit the new versions. Such a thing would need to be
open and merged within hours (or maybe one of us should just commit it
directly) so it doesnt lead to more conflicts. I always end up changing
them in TextMate because of issues like this.

---

Reply to this email directly or view it on GitHub:
#672 (comment)