Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up and small fix #2

Merged
merged 1 commit into from
Nov 14, 2012
Merged

Tidy up and small fix #2

merged 1 commit into from
Nov 14, 2012

Conversation

pjrobertson
Copy link
Member

Project tidy up and a fix that means when in the Command builder (triggers prefs) the proxy objects aren't resolved (and you don't get a hang/can show more actions.)

Means that when in the Command builder (triggers prefs) the proxy objects aren't resolved
@skurfer
Copy link
Member

skurfer commented Nov 12, 2012

Can we do anything about the exceptions thrown by Current Document?

quicksilver/Quicksilver#1162 (comment)

Update: GitHub is trying to be helpful and making that link useless as a result. Basically, the Current Document proxy throws NSAccessibilityException pretty frequently.

@pjrobertson
Copy link
Member Author

OK, I'll look into it :)

On 12 November 2012 15:08, Rob McBroom notifications@github.com wrote:

Can we do anything about the exceptions thrown by Current Document?

quicksilver/Quicksilver#1162quicksilver/Quicksilver#1162 (comment)


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-10290816.

@skurfer
Copy link
Member

skurfer commented Nov 12, 2012

any ideas how I can reproduce the exception? Other than re-instating your reverted commit?

Hmmm. No, I can't seem to reproduce it now. I noticed it when proxy objects were being added to the third pane, but then I was able to reproduce it by just calling up Current Document in the first pane. Maybe it was a particular application, but I can't find which. I've had the UI Access plug-in disabled since then, but I'll turn it back on and let you know if I see it again. I guess just forget it for now.

@pjrobertson
Copy link
Member Author

Alright, thanks :)

On 12 November 2012 20:55, Rob McBroom notifications@github.com wrote:

any ideas how I can reproduce the exception? Other than re-instating
your reverted commit?

Hmmm. No, I can't seem to reproduce it now. I noticed it when proxy
objects were being added to the third pane, but then I was able to
reproduce it by just calling up Current Document in the first pane. Maybe
it was a particular application, but I can't find which. I've had the UI
Access plug-in disabled since then, but I'll turn it back on and let you
know if I see it again. I guess just forget it for now.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-10303906.

skurfer added a commit that referenced this pull request Nov 14, 2012
@skurfer skurfer merged commit 969bdfd into quicksilver:master Nov 14, 2012
@skurfer
Copy link
Member

skurfer commented Nov 14, 2012

Go ahead with DeMinimizer too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants