Skip to content

Commit

Permalink
Using a runtime with no lifo slot.
Browse files Browse the repository at this point in the history
As spotted by @PSeitz, the unstealable lifo-slot is causing the
doc processor and the indexer to run on the same thread.
  • Loading branch information
fulmicoton committed Mar 21, 2024
1 parent ab9b243 commit 353444d
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ env:
QW_TEST_DATABASE_URL: postgres://quickwit-dev:quickwit-dev@localhost:5432/quickwit-metastore-dev
RUST_BACKTRACE: 1
RUSTDOCFLAGS: -Dwarnings -Arustdoc::private_intra_doc_links
RUSTFLAGS: -Dwarnings
RUSTFLAGS: "--cfg tokio_unstable -Dwarnings"

# Ensures that we cancel running jobs for the same PR / same workflow.
concurrency:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ env:
QW_S3_ENDPOINT: "http://localhost:4566" # Services are exposed as localhost because we are not running coverage in a container.
QW_S3_FORCE_PATH_STYLE_ACCESS: 1
QW_TEST_DATABASE_URL: postgres://quickwit-dev:quickwit-dev@localhost:5432/quickwit-metastore-dev
RUSTFLAGS: "--cfg tokio_unstable"

jobs:
test:
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ QUESTIONS.txt
.idea
.vscode
.vscode-license
.cargo
deps
qwdata
elastic-search-artifacts
Expand Down
2 changes: 2 additions & 0 deletions quickwit/.cargo/config.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[build]
rustflags = ["--cfg", "tokio_unstable"]
2 changes: 2 additions & 0 deletions quickwit/quickwit-common/src/runtimes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ fn start_runtimes(config: RuntimesConfig) -> HashMap<RuntimeType, Runtime> {
format!("blocking-{id}")
})
.enable_all()
.disable_lifo_slot()
.build()
.unwrap();
runtimes.insert(RuntimeType::Blocking, blocking_runtime);
Expand All @@ -103,6 +104,7 @@ fn start_runtimes(config: RuntimesConfig) -> HashMap<RuntimeType, Runtime> {
format!("non-blocking-{id}")
})
.enable_all()
.disable_lifo_slot()
.build()
.unwrap();
runtimes.insert(RuntimeType::NonBlocking, non_blocking_runtime);
Expand Down

0 comments on commit 353444d

Please sign in to comment.